Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124920 - Fix for Gentoo themes in gdm-2.8.0.7
Summary: Fix for Gentoo themes in gdm-2.8.0.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Highest normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://shots.osdir.com/slideshows/sli...
Whiteboard:
Keywords:
: 104123 (view as bug list)
Depends on:
Blocks: 119872
  Show dependency tree
 
Reported: 2006-03-04 02:27 UTC by Wiktor Wandachowicz
Modified: 2006-04-14 14:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gentoo-gdm-theme-r2.patch (gentoo-gdm-theme-r2.patch,50.43 KB, patch)
2006-03-04 02:32 UTC, Wiktor Wandachowicz
Details | Diff
gdm-2.8.0.7.ebuild.diff (gdm-2.8.0.7.ebuild.diff,338 bytes, patch)
2006-03-04 02:41 UTC, Wiktor Wandachowicz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wiktor Wandachowicz 2006-03-04 02:27:51 UTC
After seeing the screenshots of the walkthrough of the Gentoo 2006.0 installer
it reminded me of the gdm fonts and translation problems. So I decided to
give it another try, with good results.

After short investigation I've found out that the new versions of the default
themes (namely, circles, happygnome and happygnome-list) do not contain
the translated texts for labels anymore. Instead they use a <stock type="">
tag, which moves the translations out of the themes' .xml files to the regular
.po files. This way texts can be translated once for all themes, which looks
like a Good Thing (TM) IMO.

Knowing this fact I made a patch against gentoo-gdm-theme-r2 tarball.
Changes to the gentoo-emergence theme are based on the gdm's circles theme
(font sizes and stock label captions), while changes to the gentoo-cow
theme include only the updated stock captions.

The patch should be applied to the contents of gentoo-gdm-theme-r2.tar.bz2
file. This way an updated gentoo-gdm-theme-r3.tar.bz2 file and an updated
gdm-2.8.0.7-r2.ebuild could be created and put into portage. Since the changes
are based on the stable gdm version, they could probably be in ~arch only
for a short period of time. After all, the original gdm themes work pretty
well and this patch just makes the Gentoo themes compatible.

I hope this will be a happy ending to the two bugs regarding the same issue,
a bug #96585 and a bug #104123.

Friendly,
Comment 1 Wiktor Wandachowicz 2006-03-04 02:32:33 UTC
Created attachment 81276 [details, diff]
gentoo-gdm-theme-r2.patch

This patch makes the two Gentoo gdm themes, gentoo-emergence and gentoo-cow,
compatible with the rest of gdm themes. Essentially, it removes all the <text>
tags in favor of <stock> tags used by newer gdm.
Comment 2 Wiktor Wandachowicz 2006-03-04 02:41:37 UTC
Created attachment 81277 [details, diff]
gdm-2.8.0.7.ebuild.diff

Proof-of-concept patch against gdm-2.8.0.7.ebuild file.
It shouldn't be put in the portage, obviously, as it contains an epatch
invocation and requires the presence of files/gentoo-gdm-theme-r2.patch

Instead, an updated gdm ebuild that depends on the updated
gentoo-gdm-theme-r3.tar.bz2 file should be created.

Side note:
After using the previous patch the gentoo-emergence.xml and gentoo-cow.xml
files dropped down in size from 35kB to 8kB and from 20kB to 7kB respectively.
I think this is a good sign. :-)
Comment 3 Wiktor Wandachowicz 2006-03-04 04:42:49 UTC
Just one more comment. The fonts in gentoo-emergence were once "Sans 12".
Then, around half of a year ago, they were changed to "Sans 14". IMO, this
was a mistake, since it made several translated texts to reach over the
right edge of the screen -> aesthetically unpleasant.
I suppose this was done in order to "magnify" the fonts for higher
resolutions, like 1600x1200. But in 1024x768 the 14pt Sans font is just
too big...

The patch I've proposed reverts to the "Sans 12" - exactly like it is in
the gdm's circles theme. And the latter is given as an exemplary theme,
well translated and well designed. So, it's up to you. Please decide.

HTH,
Comment 4 Wiktor Wandachowicz 2006-03-23 23:33:11 UTC
I'm sorry to CC all of you, but this bug (#124920) has been left unseen for almost two weeks already and I'd like someone to answer. The fix is provided, so all that's left is to put a new version of gentoo-gdm-theme-r*.tar.bz2 in portage. If it qualifies, of course.

While stablizing Gnome 2.14, why not fix this long standing issue with translation of the Gentoo GDM themes at the same time?

Friendly,
Wiktor Wandachowicz
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-03-24 00:42:26 UTC
(In reply to comment #4)
> I'm sorry to CC all of you, but this bug (#124920) has been left unseen for
> almost two weeks already and I'd like someone to answer. The fix is provided,
> so all that's left is to put a new version of gentoo-gdm-theme-r*.tar.bz2 in
> portage. If it qualifies, of course.

All those people are either on gnome alias already, or don't have anything to do w/ gnome (like me). No point in spamming them. 
Comment 6 Wiktor Wandachowicz 2006-03-24 04:42:46 UTC
(In reply to comment #5)
> All those people are either on gnome alias already, or don't have anything to
> do w/ gnome (like me). No point in spamming them. 

I apologize. I didn't know that gnome alias does the job. I just took the
nicknames from the ebuild and discussions in the aforementioned bugs.
Once again I apologize.

Look, for me with my personal overlay it's not a problem. It's just all the
other Gentoo users who don't have enough luck to know about the issue.
I took my time and I analyzed the problem. IMO I've found a clean solution.
All that's left is to take 20 minutes of your precious time and apply the
fix. Alternatively you can of course close the bug, but it wouldn't remove
the problem.

Is the following other themes' .xml structure and using <stock type="">
labels considered bad? Is it really better to keep the translated text
inside the .xml instead of using the unified/translated gdm's .po files?
Judge by yourself, but then keep it proffessional and don't complain
that something is wrong, like (quoting foser):

 " the gentoo themes are broken translation wise,
   thats why they're not defaulted to anymore. "

 http://bugs.gentoo.org/show_bug.cgi?id=96585#c3

I don't want to delve deeper than that, but I felt insulted once by that
answer and despite this I still offered help (but I was ignored):

http://bugs.gentoo.org/show_bug.cgi?id=104123#c8

Now it's my third and last attempt, with analysis, solution, description
and proper patches (yes, I've finally got to know how to make them right).
Just click any of "Diff" links in the patch table to see what I mean.

The issue is over 9 months old today. Maybe something should be born
from it at last? ;-D
Comment 7 foser (RETIRED) gentoo-dev 2006-04-13 09:54:38 UTC
looks good to me, lets give it a whirl.
Comment 8 foser (RETIRED) gentoo-dev 2006-04-14 04:09:41 UTC
*** Bug 104123 has been marked as a duplicate of this bug. ***
Comment 9 foser (RETIRED) gentoo-dev 2006-04-14 04:16:20 UTC
updated gentoo-gdm-themes to r3 with the (fixed) patch proposed here. 2.14.1 now uses it.

To be fair, this is the first time the solution is acceptable, so I would read the other reports in their context instead of misquoting me.

Thanks for sticking with it and proposing this fix.

Comment 10 Wiktor Wandachowicz 2006-04-14 14:10:57 UTC
(In reply to comment #9)
> To be fair, this is the first time the solution is acceptable,
Exactly.

> so I would read
> the other reports in their context instead of misquoting me.
Point taken. :)

> Thanks for sticking with it and proposing this fix.
It's always good to see a nice "thanks" from a Gentoo developer.
Thanks for putting the updated version in Portage!