1. pidfile should not be configurable (sensord) 2. use $RC_SVCNAME in pidfile for pid uniqueness & genericness - maybe also interpret the variables inline? 3. should the user be able to remove the default _SSDARGS? (fanservice, sensord) - "You can use this configuration option to pass additional options"
Created attachment 932904 [details, diff] openrc service scripts patch Please take a look
Looks good, I think points 1 & 2 are solved! Since the service script are being changed either way I also have one suggestion; to shorten lm_sensors' stop function like this: stop(){ :; } It behaves the same but is much shorter and more readable.
(In reply to Filip Kobierski from comment #2) > Looks good, I think points 1 & 2 are solved! > > Since the service script are being changed either way I also have one > suggestion; > to shorten lm_sensors' stop function like this: > > stop(){ :; } > > It behaves the same but is much shorter and more readable. Thank-you for your response. I'll grab the 'stop' item above, and commit.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46c71991c2f1138679d74e6c8973fd2b68a30084 commit 46c71991c2f1138679d74e6c8973fd2b68a30084 Author: Mike Pagano <mpagano@gentoo.org> AuthorDate: 2025-06-12 15:26:39 +0000 Commit: Mike Pagano <mpagano@gentoo.org> CommitDate: 2025-06-12 15:26:39 +0000 sys-apps/lm-sensors/files: openrc service scripts clean-up Remove configurability of pid file Utilize RC_SVCNAME for pidfile Clean-up stop function Thanks to Filip Kobierski for the collaboration Closes: https://bugs.gentoo.org/957613 Signed-off-by: Mike Pagano <mpagano@gentoo.org> sys-apps/lm-sensors/files/fancontrol.initd | 11 ++++++----- sys-apps/lm-sensors/files/lm_sensors.initd | 5 +---- sys-apps/lm-sensors/files/sensord.initd | 14 +++++++------- 3 files changed, 14 insertions(+), 16 deletions(-)
