Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 955416 - net-vpn/i2pd: merge system service files with upstream's
Summary: net-vpn/i2pd: merge system service files with upstream's
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Alexey Korepanov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2025-05-04 12:38 UTC by Filip Kobierski
Modified: 2025-05-21 21:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Kobierski 2025-05-04 12:38:11 UTC
Right now upstream supports openrc with a init.d file
https://github.com/PurpleI2P/i2pd/tree/openssl/contrib/openrc
and we install our own init.d & conf.d files:
https://gitweb.gentoo.org/repo/gentoo.git/tree/net-vpn/i2pd/i2pd-2.56.0.ebuild#n60

I think merging our files together would benefit both projects.

I am willing to do this work but before I do I would like someone to confirm that they will review my changes before I open up a PR upstream.

That is also the case with systemd but since I do not use it I am not that eager to work on it.
Comment 1 Alexey Korepanov 2025-05-06 07:03:56 UTC
Hi.

It would be great if you merge the openrc files. I maintain i2pd in portage, but I don't really use openrc, so maintaining the openrc side is difficult. I'll be happy to look at the changes though.

There's this bug which might be fixed along the way:
https://bugs.gentoo.org/show_bug.cgi?id=949988
Comment 2 Filip Kobierski 2025-05-06 22:56:45 UTC
I have increased the importance as I think it improve the package significantly.
Both 949988 & 808845 would have been avoided if we used upstream service files.
Comment 3 Larry the Git Cow gentoo-dev 2025-05-21 21:51:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b63d81cc7eee01fd502897d82767876ac52280fc

commit b63d81cc7eee01fd502897d82767876ac52280fc
Author:     Filip Kobierski <fkobi@pm.me>
AuthorDate: 2025-05-06 15:42:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-05-21 21:47:57 +0000

    net-vpn/i2pd: add 2.56.0-r1 with improved openrc files
    
    Basically a rewrite at this point
    
    Added:
    - name
    - reload command
    - required_{dirs,files}
    - command_args_background
    - I2PD_LOGLEVEL
    - default USER & GROUP
    - confd file header
    Fixed:
    - pidfile usage
      - properly fix for #808845
      - part of #949988 (bad shutdown)
    - not changing group
    Changed:
    - hardcode pidfile path to /run/i2pd/
    - use command_progress instead of --progress
    - use command_user instead of --user
    - change `retry` timeouts to match upstream
    - always run with --daemon --service --log=file
    - rename OPTIONS to ARGS & add default value
    - rename LOG to LOGFILE & add default value
    - graceful command:
      - drop eval
      - use $retry
    - style
      - group subcommands stuff at the bottom
      - indent stuff
      - unquote known atomic constants
      - use " instead of ' for strings
      - confd: move unprefixed rc_ulimit to the bottom
    Removed:
    - use netmount
    - I2P_PID_DIR
    
    Bug: https://bugs.gentoo.org/808845
    Bug: https://bugs.gentoo.org/949988
    Bug: https://bugs.gentoo.org/955416
    Signed-off-by: Filip Kobierski <fkobi@pm.me>
    Part-of: https://github.com/gentoo/gentoo/pull/41968
    Closes: https://github.com/gentoo/gentoo/pull/41968
    Signed-off-by: Sam James <sam@gentoo.org>

 net-vpn/i2pd/files/i2pd-2.56.0.confd | 16 ++++++++
 net-vpn/i2pd/files/i2pd-2.56.0.initd | 53 +++++++++++++++++++++++++
 net-vpn/i2pd/i2pd-2.56.0-r1.ebuild   | 76 ++++++++++++++++++++++++++++++++++++
 3 files changed, 145 insertions(+)