Created attachment 927232 [details] build.log ``` make: Entering directory '/var/tmp/portage/dev-util/bpftool-7.5.0/work/bpftool-libbpf-v7.5.0-sources/src' bpf-unknown-none-gcc \ -I. \ -I/var/tmp/portage/dev-util/bpftool-7.5.0/work/bpftool-libbpf-v7.5.0-sources/include/uapi/ \ -I/var/tmp/portage/dev-util/bpftool-7.5.0/work/bpftool-libbpf-v7.5.0-sources/src/bootstrap/libbpf/include \ -g -O2 -Wall -fno-stack-protector \ -c skeleton/profiler.bpf.c -o profiler.bpf.o In file included from skeleton/profiler.bpf.c:3: ./vmlinux.h:5: warning: ignoring '#pragma clang attribute' [-Wunknown-pragmas] 5 | #pragma clang attribute push (__attribute__((preserve_access_index)), apply_to = record) ./vmlinux.h:9845:9: error: cannot use keyword 'false' as enumeration constant 9845 | false = 0, | ^~~~~ ./vmlinux.h:9845:9: note: 'false' is a keyword with '-std=c23' onwards ./vmlinux.h:31137:15: error: 'bool' cannot be defined via 'typedef' 31137 | typedef _Bool bool; | ^~~~ ./vmlinux.h:31137:15: note: 'bool' is a keyword with '-std=c23' onwards ./vmlinux.h:31137:1: warning: useless type name in empty declaration 31137 | typedef _Bool bool; | ^~~~~~~ ./vmlinux.h:170029: warning: ignoring '#pragma clang attribute' [-Wunknown-pragmas] 170029 | #pragma clang attribute pop make: *** [Makefile:209: profiler.bpf.o] Error 1 make: Leaving directory '/var/tmp/portage/dev-util/bpftool-7.5.0/work/bpftool-libbpf-v7.5.0-sources/src' make: *** Waiting for unfinished jobs.... ``` --- $ emerge --info Portage 3.0.68-4+g6a2bd8589-dirty (python 3.13.3-final-0, default/linux/amd64/23.0/hardened, gcc-16, glibc-2.41.9999, 6.14.4 x86_64) ================================================================= System uname: Linux-6.14.4-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.41 KiB Mem: 65737640 total, 21405820 free KiB Swap: 16662520 total, 6062180 free Timestamp of repository gentoo: Wed, 30 Apr 2025 21:35:19 +0000 Head commit of repository gentoo: 7c4907d6aa0b4b13e1b485731ffce27ecc253557 Timestamp of repository kde: Tue, 29 Apr 2025 18:35:16 +0000 Head commit of repository kde: b0a09d277bde31590453503129e006b4d49342af Timestamp of repository qt: Thu, 24 Apr 2025 20:35:11 +0000 Head commit of repository qt: 27210069680334182c0ebf5302465e79d472a2a0 Timestamp of repository sam_c: Wed, 23 Apr 2025 15:38:27 +0000 Head commit of repository sam_c: 3f677b54b92b5ad9aacd00724e6b9f205ea7aee4 sh dash 0.5.12-r1 ld GNU ld (Gentoo 9999 p1) 2.44.50.20250501 ccache version 4.11.2 [disabled] app-misc/pax-utils: 1.3.8::gentoo app-shells/bash: 5.3_rc1_p20250422::gentoo dev-build/autoconf: 2.13-r8::gentoo, 2.69-r9::gentoo, 2.72-r1::gentoo, 9999::gentoo dev-build/automake: 1.17-r2::gentoo dev-build/cmake: 3.31.7::gentoo dev-build/libtool: 2.5.4::gentoo dev-build/make: 4.4.1-r100::gentoo dev-build/meson: 9999::gentoo dev-java/java-config: 2.3.4::gentoo dev-lang/perl: 5.40.2::gentoo dev-lang/python: 3.10.17::gentoo, 3.11.12::gentoo, 3.12.10::gentoo, 3.13.3::gentoo, 3.13.3-r100::gentoo dev-lang/rust: 1.86.0-r1::gentoo dev-util/ccache: 4.11.2::gentoo llvm-core/clang: 18.1.8-r6::gentoo, 19.1.7::gentoo, 20.1.3::gentoo llvm-core/lld: 20.1.3::gentoo llvm-core/llvm: 18.1.8-r6::gentoo, 19.1.7::gentoo, 20.1.3::gentoo sys-apps/baselayout: 2.17::gentoo sys-apps/sandbox: 2.46::gentoo sys-apps/systemd: 257.5::gentoo sys-devel/binutils: 2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r9::gentoo, 2.41-r5::gentoo, 2.42-r2::gentoo, 2.43-r2::gentoo, 2.44::gentoo, 9999::gentoo sys-devel/binutils-config: 5.5.2::gentoo sys-devel/gcc: 10.5.0::gentoo, 11.5.0::gentoo, 12.4.1_p20250417::gentoo, 13.3.1_p20250424::gentoo, 14.2.1_p20250425::gentoo, 15.1.1_p20250426::gentoo, 16.0.9999::gentoo sys-devel/gcc-config: 2.12.1::gentoo sys-kernel/linux-headers: 6.14::gentoo (virtual/os-headers) sys-libs/glibc: 2.41.9999::sam_c Repositories: gentoo location: /var/db/repos/gentoo sync-type: git sync-uri: https://github.com/gentoo-mirror/gentoo.git priority: -1000 eclass-overrides: sam_c volatile: False sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now sync-git-verify-commit-signature: yes crossdev location: /var/db/repos/crossdev masters: gentoo eclass-overrides: sam_c volatile: False kde location: /var/db/repos/kde sync-type: git sync-uri: https://github.com/gentoo-mirror/kde.git masters: gentoo eclass-overrides: sam_c volatile: False local location: /var/db/repos/local masters: gentoo eclass-overrides: sam_c volatile: False qt location: /var/db/repos/qt sync-type: git sync-uri: https://github.com/gentoo-mirror/qt.git masters: gentoo eclass-overrides: sam_c volatile: False sam_c location: /var/db/repos/sam_c sync-type: git sync-uri: https://github.com/gentoo-mirror/sam_c.git masters: gentoo eclass-overrides: sam_c volatile: False Binary Repositories: binhost priority: 9999 sync-uri: https://www.mirrorservice.org/sites/distfiles.gentoo.org/releases/amd64/binpackages/23.0/x86-64 Installed sets: @sam-emacs, @sam-fonts, @sam-fortune, @sam-tests ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Wstrict-aliasing -Wfree-nonheap-object -Wuninitialized -Wmaybe-uninitialized -Wreturn-type -Wbuiltin-declaration-mismatch -Wtautological-compare" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Wstrict-aliasing -Wfree-nonheap-object -Wuninitialized -Wmaybe-uninitialized -Wreturn-type" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg=y --implicit-system-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --jobs=4 --load-average 32" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 " FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs config-protect-if-modified distlocks export-pms-vars fixlafiles ipc-sandbox merge-wait mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 " GENTOO_MIRRORS="https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/" LANG="en_GB.UTF-8" LDFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr -Warray-bounds -fdiagnostics-details -Wstringop-overread -Wstringop-overflow -Wstringop-truncation -Wformat-overflow -Wformat-truncation -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=jobserver -Wl,--defsym=__gentoo_check_ldflags__=0" LEX="reflex" LINGUAS="en en_GB" MAKEOPTS="-j32 -l32" PKGDIR="/var/cache/binpkgs" PORTAGE_BUNZIP2_COMMAND="lbunzip2" PORTAGE_COMPRESS="xz" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs" SHELL="/bin/bash" USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libnotify libtirpc lto mad mmx mmxext mng modules-compress mp3 mp4 mpeg multilib ncurses nftables nls ogg opengl openmp pam pango pclmul pcre pdf pgo pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 qt6 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gcc_14" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GUILE_SINGLE_TARGET="3-0" GUILE_TARGETS="3-0" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-2" POSTGRES_TARGETS="postgres17" PYTHON_SINGLE_TARGET="python3_13" PYTHON_TARGETS="python3_12 pypy3 pypy3_11 python3_10 python3_11 python3_13 python3_13t" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa i386 m68k ppc ppc64 ppc64le sparc sparc64 x86_64" RUBY_TARGETS="ruby32 ruby33 ruby34" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account" YACC="byacc" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
I was scratching my head as to how we hadn't hit this earlier, then realised it's because this specific part is built w/ bpf-toolchain (which indeed defaults to -std=gnu23, but I wasn't using snapshots for that, so only seeing it now w/ the release). But it's the same problem as we've seen in the rest of the kernel.
I completely missed that you added 15.1.0 already, otherwise I would have tried myself. This happens in the embedded, statically linked part of bpftool's libbpf so I guess I'll try to sprinkle some gnu11 in there.
(In reply to Holger Hoffstätte from comment #2) > I'll try to sprinkle some gnu11 in there. That worked and it builds. However vmlinux.h generates a lot of warnings for attributes like .e.g.: ./vmlinux.h:20192:17: warning: 'btf_type_tag' attribute directive ignored [-Wattributes] 20192 | void __attribute__((btf_type_tag("user"))) *user; | ^~~~ Not sure if those are new with 15 (can you verfiy with toolchain-14?) but somehow I get the feeling these should not happen.
In related good news: the bpf deduplication seems to work as expected, as the bpftool executable built with toolchain-15 is now even smaller (a few KB) than one built with clang.
Also new are libelf warnings: $sudo /tmp/portage/dev-util/bpftool-7.5.0/image/usr/sbin/bpftool prog show libbpf: elf: skipping section(2) .data (size 0) libbpf: elf: skipping unrecognized data section(10) .comment 2: tracing name dump_bpf_map tag db082b09ac2b3688 gpl loaded_at 2025-04-30T20:08:29+0200 uid 0 xlated 280B jited 167B memlock 4096B map_ids 2 btf_id 83 3: tracing name dump_bpf_prog tag b6592473121581e5 gpl loaded_at 2025-04-30T20:08:29+0200 uid 0 xlated 520B jited 737B memlock 4096B map_ids 2 btf_id 83 14: xdp name xdp_dispatcher tag 67ac9f30075bab16 gpl loaded_at 2025-04-30T20:08:30+0200 uid 0 xlated 160B jited 120B memlock 4096B map_ids 7 btf_id 98 23: ext name homeplug_drop tag fbd415544de357c1 gpl loaded_at 2025-04-30T20:08:30+0200 uid 0 xlated 136B jited 92B memlock 4096B btf_id 101
Both the attribute warnings and the libelf messages also happen with 14.2.0_p2, so at least they are consistent. I don't remember if they happened before.
Created attachment 927284 [details, diff] Patch to build with bpf-toolchain-15 Unconditionally add std=gnu11 for the bpf bits linked into the bpftool executable. This works with both bpf-toolchain and clang.
The patch is simple enough, makes it build/work and should be good enough for now, especially considering that we still default to clang. Let me know what you think. The warning messages seem benign, though I'm not sure why a 0-sized data section or a .comment are not just ignored.
Also: https://gcc.gnu.org/pipermail/gcc-patches/2025-January/673841.html
(In reply to Holger Hoffstätte from comment #9) > Also: https://gcc.gnu.org/pipermail/gcc-patches/2025-January/673841.html Ackshually v2 from last night :-) https://gcc.gnu.org/pipermail/gcc-patches/2025-April/682340.html
(In reply to Holger Hoffstätte from comment #9) > Also: https://gcc.gnu.org/pipermail/gcc-patches/2025-January/673841.html Latest version is https://inbox.sourceware.org/gcc-patches/20250430172344.240648-1-david.faust@oracle.com/. (In reply to Holger Hoffstätte from comment #2) > I completely missed that you added 15.1.0 already, otherwise I would have > tried myself. This happens in the embedded, statically linked part of > bpftool's libbpf so I guess I'll try to sprinkle some gnu11 in there. Sorry, I'd meant to ping you for it as I knew you'd be interested! (In reply to Holger Hoffstätte from comment #4) > In related good news: the bpf deduplication seems to work as expected, as > the bpftool executable built with toolchain-15 is now even smaller (a few > KB) than one built with clang. \o/ (In reply to Holger Hoffstätte from comment #7) > Created attachment 927284 [details, diff] [details, diff] > Patch to build with bpf-toolchain-15 > > Unconditionally add std=gnu11 for the bpf bits linked into the bpftool > executable. This works with both bpf-toolchain and clang. LGTM (but not tried it yet).
Made a PR and will also send the change to upstream. I expect it will take a while for this to materialize in the bpftool GH mirror.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf70fbf7b0dc97fbc97af579954ea81a8df36113 commit bf70fbf7b0dc97fbc97af579954ea81a8df36113 Author: Holger Hoffstätte <holger@applied-asynchrony.com> AuthorDate: 2025-05-01 17:27:57 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-05-02 04:37:27 +0000 dev-util/bpftool: always build bpf bits with std=gnu11, remove py3.10 The bpf-toolchain-15 compiler defaults to C23, which fails to compile various kernel headers due to their use of a custom 'bool' type. Explicitly using -std=gnu11 works with both clang and bpf-toolchain. Closes: https://bugs.gentoo.org/955156 Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com> Part-of: https://github.com/gentoo/gentoo/pull/41884 Signed-off-by: Sam James <sam@gentoo.org> dev-util/bpftool/bpftool-7.5.0.ebuild | 5 ++++- dev-util/bpftool/bpftool-9999.ebuild | 7 +++++-- 2 files changed, 9 insertions(+), 3 deletions(-)
Patch submitted upstream: https://lore.kernel.org/bpf/20250502085710.3980-1-holger@applied-asynchrony.com/
