Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 954233 - sci-visualization/kst-2.1.0_p20250415: includes broken cmake/modules/FindHDF5.cmake
Summary: sci-visualization/kst-2.1.0_p20250415: includes broken cmake/modules/FindHDF5...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-23 08:37 UTC by Michał Górny
Modified: 2025-04-23 17:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2025-04-23 08:37:06 UTC
Noticed while testing (a new) hdf5 CMake port:

CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:441 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (HDF5).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:114 (find_package_handle_standard_args)
  cmake/modules/FindHDF5.cmake:20 (include)
  CMakeLists.txt:160 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Not found: HDF5.
--       If HDF5 is installed outside the CMake search path,
--       set the environmental variable HDF5_DIR to the
--       HDF5 install prefix.


If I remove cmake/modules/FindHDF5.cmake, it successfully builds using upstream HDF5 CMake files (but I suspect it won't work with autotools, haven't tested).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2025-04-23 08:40:49 UTC
That said, in both cases it definitely passes `-lhdf5` at build time, but it gets stripped by as-needed.
Comment 2 Larry the Git Cow gentoo-dev 2025-04-23 17:50:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d3a60bd4f4bd03d8c8d123e9dbf01e12cb9480a

commit 1d3a60bd4f4bd03d8c8d123e9dbf01e12cb9480a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-04-23 17:43:27 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-04-23 17:50:19 +0000

    sci-visualization/kst: Use upstream FindHDF5.cmake module
    
    And make some minor adjustments so it actually gets picked up.
    
    Closes: https://bugs.gentoo.org/954233
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/kst-2.1.0_p20250415-cmake-findgsl.patch  | 92 +++-------------------
 .../files/kst-2.1.0_p20250415-cmake-findhdf5.patch | 43 ++++++++++
 .../kst/kst-2.1.0_p20250415-r1.ebuild              | 84 ++++++++++++++++++++
 3 files changed, 137 insertions(+), 82 deletions(-)