Bug 953776 – net-misc/remmina-1.4.40: Remmina-v1.4.40/plugins/rdp/rdp_monitor.c:195:9: error: implicit declaration of function ‘freerdp_settings_set_monitor_def_array_sorted’; did you mean ‘freerdp_settings_set_pointer_array’?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Samuel Bernardo 2025-04-13 09:56:49 UTC]

Created attachment 924623 [details]
build.log

FAILED: plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_monitor.c.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc -DFREERDP_REQUIRED_MAJOR=3 -DFREERDP_REQUIRED_MINOR=0 -DFREERDP_REQUIRED_REVISION=0 -DHAVE_CUPS -DHAVE_LIBGCRYPT -DHAVE_LIBSSH -DWITH_MANPAGES -DWITH_NEWS -DWITH_STATS -DWITH_TIP -Dremmina_plugin_rdp_EXPORTS -I/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/. -I/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/src/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/lib64/libffi/include -I/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40_build/generated -I/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/plugins -I/usr/include/freerdp3 -isystem /usr/include/winpr3  -O2 -pipe -march=native -Werror=incompatible-pointer-types -fPIC -Wall -g -fPIC -MD -MT plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_monitor.c.o -MF plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_monitor.c.o.d -o plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_monitor.c.o -c /var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/plugins/rdp/rdp_monitor.c
/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/plugins/rdp/rdp_monitor.c: In function ‘remmina_rdp_monitor_get’:
/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/plugins/rdp/rdp_monitor.c:195:9: error: implicit declaration of function ‘freerdp_settings_set_monitor_def_array_sorted’; did you mean ‘freerdp_settings_set_pointer_array’? [-Wimplicit-function-declaration]
  195 |         freerdp_settings_set_monitor_def_array_sorted(settings, rdp_monitors, index);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         freerdp_settings_set_pointer_array
/var/tmp/portage/net-misc/remmina-1.4.40/work/Remmina-v1.4.40/plugins/rdp/rdp_monitor.c:107:21: warning: unused variable ‘base’ [-Wunused-variable]
  107 |         rdpMonitor* base = (rdpMonitor *)freerdp_settings_get_pointer(settings, FreeRDP_MonitorDefArray);
      |                     ^~~~
ninja: build stopped: subcommand failed.
 * ERROR: net-misc/remmina-1.4.40::gentoo failed (compile phase):
 *   ninja -v -j9 -l8 failed
 * 
 * Call stack:
 *     ebuild.sh, line  136:  Called src_compile
 *   environment, line 2803:  Called cmake_src_compile
 *   environment, line 1220:  Called cmake_build
 *   environment, line 1187:  Called eninja
 *   environment, line 1515:  Called die
 * The specific snippet of code:
 *       "$@" || die -n "${*} failed"

[Comment 1 Samuel Bernardo 2025-04-13 09:57:14 UTC]

Created attachment 924624 [details]
emerge.pqv

[Comment 2 Samuel Bernardo 2025-04-13 09:57:34 UTC]

Created attachment 924625 [details]
emerge.info

[Comment 3 Samuel Bernardo 2025-04-13 10:05:06 UTC]

It seems that the missing function is only available from remmina-3.11:
https://github.com/FreeRDP/FreeRDP/blob/accfec9a2778e9512cb4ab93e0e8e660d21ef02b/include/freerdp/settings.h#L755-L774

The dependencies in remmina ebuild should be corrected to require at least remmina-3.11. Current remmina stable release is 3.9.0.

[Comment 4 Samuel Bernardo 2025-04-13 10:06:53 UTC]

(In reply to Samuel Bernardo from comment #3)
> It seems that the missing function is only available from remmina-3.11:
> https://github.com/FreeRDP/FreeRDP/blob/
> accfec9a2778e9512cb4ab93e0e8e660d21ef02b/include/freerdp/settings.h#L755-L774
> 
> The dependencies in remmina ebuild should be corrected to require at least
> remmina-3.11. Current remmina stable release is 3.9.0.

Just correcting my last message:
when I mention remmina-3.11 I mean freerdp-3.11 and current freerdp stable release is 3.9.0.

[Comment 5 Samuel Bernardo 2025-04-13 11:23:12 UTC]

remmina-1.4.40 compiled correctly with freerdp-3.14.1.
There wasn't any issue with dependencies with default/linux/amd64/23.0/systemd profile with customized plasma desktop use flags.

[Comment 6 Alexander Petermann 2025-04-23 07:50:11 UTC]

(In reply to Samuel Bernardo from comment #5)
> remmina-1.4.40 compiled correctly with freerdp-3.14.1.
> There wasn't any issue with dependencies with
> default/linux/amd64/23.0/systemd profile with customized plasma desktop use
> flags.

I have default/linux/amd64/23.0/desktop/systemd selected and got the error with stable net-misc/freerdp-3.9.0-r1.

I got remmina-1.4.40 to compile, after updating to freerdp-3.14.1, like you said.

[Comment 7 Larry the Git Cow 2025-04-23 07:57:23 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=412d4b178e33bf196e1a34394f7bf0ed558bdeea

commit 412d4b178e33bf196e1a34394f7bf0ed558bdeea
Author:     Sam James <[e-mail]>
AuthorDate: 2025-04-23 07:56:35 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-04-23 07:56:56 +0000

    net-misc/remmina: depend on >=freerdp-3.11.0
    
    ... for freerdp_settings_set_monitor_def_array_sorted.
    
    Closes: https://bugs.gentoo.org/953776
    Signed-off-by: Sam James <[e-mail]>

 net-misc/remmina/{remmina-1.4.40.ebuild => remmina-1.4.40-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)