Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 953447 - app-crypt/certbot-4.0.0: version bump
Summary: app-crypt/certbot-4.0.0: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL: https://github.com/certbot/certbot/re...
Whiteboard:
Keywords: PullRequest
Depends on: 951716
Blocks: 950439
  Show dependency tree
 
Reported: 2025-04-08 19:54 UTC by Thibaud CANALE
Modified: 2025-04-10 21:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud CANALE 2025-04-08 19:54:45 UTC
Release 4.0.0
https://github.com/certbot/certbot/releases/tag/v4.0.0
Comment 1 Larry the Git Cow gentoo-dev 2025-04-08 21:13:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45ddaeeb385ff4dd38c81fc2c74ba4709dd3ec8f

commit 45ddaeeb385ff4dd38c81fc2c74ba4709dd3ec8f
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2025-04-08 20:06:44 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2025-04-08 21:13:19 +0000

    app-crypt/certbot: add 4.0.0
    
    Closes: https://bugs.gentoo.org/953447
    Bug: https://bugs.gentoo.org/951716
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Closes: https://github.com/gentoo/gentoo/pull/41504
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 app-crypt/certbot/Manifest             |   1 +
 app-crypt/certbot/certbot-4.0.0.ebuild | 187 +++++++++++++++++++++++++++++++++
 app-crypt/certbot/certbot-9999.ebuild  | 158 +++-------------------------
 3 files changed, 205 insertions(+), 141 deletions(-)
Comment 2 Thibaud CANALE 2025-04-08 21:17:21 UTC
Matthew, the PR was in draft state, the test are not validating.

What should we do then? Would you please assist me in fixing this test issue?
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2025-04-08 21:19:09 UTC
sorry, missed that tag.

The right solution is to fix it in a rev bump.
Comment 4 Thibaud CANALE 2025-04-08 21:25:13 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #3)
> sorry, missed that tag.

Escude me to nitpick, I described its state in the main description.

> The right solution is to fix it in a rev bump.

Ok, no problem, the actual problem is I have no idea why tests are failing.
Also I take this opportunity to raise awareness about those QA messages; one among others:
```
/usr/lib/python3.12/site-packages/setuptools/command/build_py.py:212: _Warning: Package 'certbot.tests.testdata' is absent from the `packages` configuration.
```

Should we also create another ticket for this? Might be wiser to use IRC to discuss instead of this medium.
Comment 5 Larry the Git Cow gentoo-dev 2025-04-10 14:54:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57dc33daea08f8ec4d24c0e442620e24515599d1

commit 57dc33daea08f8ec4d24c0e442620e24515599d1
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2025-04-10 14:10:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-10 14:53:32 +0000

    app-crypt/certbot: fix test for 4.0.0
    
    Bug: https://bugs.gentoo.org/953447
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Closes: https://github.com/gentoo/gentoo/pull/41525
    Signed-off-by: Sam James <sam@gentoo.org>

 app-crypt/certbot/{certbot-4.0.0.ebuild => certbot-4.0.0-r1.ebuild} | 5 +++--
 app-crypt/certbot/certbot-9999.ebuild                               | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)