Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 951471 - net-misc/linuxptp-4.4: error in ebuild, doesn't build binaries
Summary: net-misc/linuxptp-4.4: error in ebuild, doesn't build binaries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2025-03-16 18:49 UTC by Kim B. Sindalsen
Modified: 2025-03-17 11:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild-patch (file_951471.txt,444 bytes, patch)
2025-03-16 18:50 UTC, Kim B. Sindalsen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim B. Sindalsen 2025-03-16 18:49:44 UTC
A missing '\' src_install part in the ebuild makes it stop from installing ie. binaries

src_install() {
        emake \
                prefix="${D}"/usr \
                mandir="${D}"/usr/share/man
                infodir="${D}"/usr/share/info \
                libdir="${D}"/usr/$(get_libdir) \
                install

should be

src_install() {
        emake \
                prefix="${D}"/usr \
                mandir="${D}"/usr/share/man \
                infodir="${D}"/usr/share/info \
                libdir="${D}"/usr/$(get_libdir) \
                install
Comment 1 Kim B. Sindalsen 2025-03-16 18:50:06 UTC
Created attachment 920942 [details, diff]
ebuild-patch
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-16 18:50:44 UTC
commit 4a9cbf9357026221359832c0bf7363470db27168
Author: Thomas Beierlein <tomjbe@gentoo.org>
Date:   Sun Dec 15 11:02:56 2024 +0100

    net-misc/linuxptp: add 4.4

    Closes: https://bugs.gentoo.org/941727
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

A good reason to always use arrays where possible.
Comment 3 Thomas Beierlein gentoo-dev 2025-03-17 09:18:39 UTC
Thanks for pointing it out. Just wondering how I could miss that.

@sam Not sure how an array could help here.
Comment 4 Larry the Git Cow gentoo-dev 2025-03-17 09:23:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=979cb27590e8215e496b4c13a18697eb5c7daf59

commit 979cb27590e8215e496b4c13a18697eb5c7daf59
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2025-03-17 09:19:16 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2025-03-17 09:22:38 +0000

    net-misc/linuxptp: Fix src_install()
    
    Closes: https://bugs.gentoo.org/951471
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

 net-misc/linuxptp/{linuxptp-4.4.ebuild => linuxptp-4.4-r1.ebuild} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-17 09:25:18 UTC
(In reply to Thomas Beierlein from comment #3)
> Thanks for pointing it out. Just wondering how I could miss that.
> 
> @sam Not sure how an array could help here.

local myemakeargs=(
    A=1

)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-17 09:25:56 UTC
Sorry, hit enter prematurely:

local myemakeargs=(
    A=1
    B=1
    ...
)
emake "${myemakeargs[@]}"

The lack of a '\' doesn't matter because arrays don't need them.
Comment 7 Thomas Beierlein gentoo-dev 2025-03-17 11:58:42 UTC
(In reply to Sam James from comment #6)
> local myemakeargs=(
>     A=1
>     B=1
>     ...
> )
> emake "${myemakeargs[@]}"
> 
> The lack of a '\' doesn't matter because arrays don't need them.

I see.  Have not seen it used often in other ebuilds. Thanks anyway.