This is not true anymore: > $(use_with udisks dbus) # dbus is only used for udisks dbus is also used for bluetooth since 10.0. The udisks USE-flag should be renamed.
Thanks, missed that. wine-9 only has dlls/mountmgr.sys/dbus.c, but wine-10 indeed added dlls/winebth.sys/dbus.c I think having wine handle the udisks dependency is not particularly useful (it's runtime-only dep), actual users will have it already without even needing to be a optfeature. Likewise, I don't think it need to check for bluez either (with a USE=bluetooth or optfeature). ..so think I'll go for a generic IUSE=+dbus instead, making it default so things work as expected out of the box without using having to wonder what they need to make udisks/bluez work.
To keep things uniform, think I'll rename it for older wine versions too.
(In reply to Alexander Tsoy from comment #0) > The udisks USE-flag should be renamed. My bad. Probably bluetooth USE flag should be introduced with runtime dependency on BlueZ. And both udisks and bluetooth USE flags should depend on dbus USE flag.
(In reply to Ionen Wolkens from comment #1) > I think having wine handle the udisks dependency is not particularly useful > (it's runtime-only dep), actual users will have it already without even > needing to be a optfeature. > > Likewise, I don't think it need to check for bluez either (with a > USE=bluetooth or optfeature). > > ..so think I'll go for a generic IUSE=+dbus instead, making it default so > things work as expected out of the box without using having to wonder what > they need to make udisks/bluez work. Ah, yes. That makes sense.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c7ac38f9f354666527766cc2f6b2578d1461ea7 commit 3c7ac38f9f354666527766cc2f6b2578d1461ea7 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2025-02-28 18:27:33 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2025-02-28 18:45:45 +0000 app-emulation/wine-*: replace IUSE=udisks by generic IUSE=+dbus This actually had been bothering me for a while, and bug #950382 is a good excuse to finally rename it. There is little reason to treat dbus communication specially and handle each services with its own USE vs just having USE=dbus. ...and per the bug, this now gained additional usage with bluetooth (and perhaps more in the future) making current USE=udisks an issue. Also feel it makes more sense enabled by default to avoid confusion, but users that know they don't need it may want to optionally disable it to skip USE=abi_x86_32 on dbus (albeit it's trivial). Note wine will not even link with libdbus, this just enables support for dlopen'ing it when needed. Unfortunately this will cause semi-unnessary rebuilds for all wine users. Closes: https://bugs.gentoo.org/950382 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> app-emulation/wine-proton/wine-proton-8.0.5c.ebuild | 11 +++++------ app-emulation/wine-proton/wine-proton-9.0.4.ebuild | 11 +++++------ app-emulation/wine-proton/wine-proton-9999.ebuild | 11 +++++------ app-emulation/wine-staging/wine-staging-10.0.ebuild | 11 +++++------ app-emulation/wine-staging/wine-staging-10.1.ebuild | 11 +++++------ app-emulation/wine-staging/wine-staging-10.2.ebuild | 11 +++++------ app-emulation/wine-staging/wine-staging-9.0.ebuild | 11 +++++------ app-emulation/wine-staging/wine-staging-9999.ebuild | 11 +++++------ app-emulation/wine-vanilla/wine-vanilla-10.0.ebuild | 11 +++++------ app-emulation/wine-vanilla/wine-vanilla-10.1.ebuild | 11 +++++------ app-emulation/wine-vanilla/wine-vanilla-10.2.ebuild | 11 +++++------ app-emulation/wine-vanilla/wine-vanilla-8.0.2.ebuild | 9 ++++----- app-emulation/wine-vanilla/wine-vanilla-9.0.ebuild | 12 ++++++------ app-emulation/wine-vanilla/wine-vanilla-9999.ebuild | 11 +++++------ 14 files changed, 70 insertions(+), 83 deletions(-)
