Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 950273 - sys-libs/libxcrypt: don't call pkg-config when USE=headers-only
Summary: sys-libs/libxcrypt: don't call pkg-config when USE=headers-only
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2025-02-25 14:42 UTC by Adrian Ratiu
Modified: 2025-02-27 17:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Ratiu 2025-02-25 14:42:16 UTC
Hello again!

I promise this will be my last libxcrypt bug report for a while because I got things working nicely now. One last minor issue. :)

I'd like to avoid calling pkg-config entirely in the USE=headers-only case because it's not necessary and during early bootstrapping (both llvm and also the bazel builds in ChromiumOS), it might end up calling the wrong host unprefixed pkg-config.

I created a patch for this and, while I'm at it, added a second patch to clarify the intended use of headers-only in metadata.xml.

Many thanks for your help with these bugs & patches!
Comment 1 Larry the Git Cow gentoo-dev 2025-02-27 17:10:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d04fa37e49523fc98d0992af4889de36042666a

commit 1d04fa37e49523fc98d0992af4889de36042666a
Author:     Adrian Ratiu <adrian.ratiu@collabora.com>
AuthorDate: 2025-02-25 14:32:03 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2025-02-27 17:09:41 +0000

    sys-devel/libxcrypt: clarify the intended use of USE=headers-only
    
    Closes: https://bugs.gentoo.org/950273
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    Closes: https://github.com/gentoo/gentoo/pull/40751
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-libs/libxcrypt/metadata.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc730b95068dab4c1719d62299e905a57221876d

commit cc730b95068dab4c1719d62299e905a57221876d
Author:     Adrian Ratiu <adrian.ratiu@collabora.com>
AuthorDate: 2025-02-25 13:45:45 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2025-02-27 17:09:37 +0000

    sys-libs/libxcrypt: avoid using pkg-config for headers-only
    
    When setting USE=headers-only, nothing gets built, and
    just some static files get installed: the two (x)crypt.h
    headers alongside the /usr/share/doc files. The usefulness
    of this is mostly for early compiler bootstrapping, to
    break circular deps like:
    compiler-rt -> libxcrypt -> complier-rt
    
    There is no need to have a working pkg-config, the env var
    PKG_CONFIG is empty, there might not even be any setup for
    cross-*/pkgconf and the configure step will likely end up
    calling the host pkg-config (which will fail my profile
    sanity checks).
    
    So we set to a known no-op value just for USE=headers-only
    leaving all the non-headers builds to pick the correct
    variant as before.
    
    Closes: https://bugs.gentoo.org/950273
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-libs/libxcrypt/libxcrypt-4.4.36-r3.ebuild | 6 ++++--
 sys-libs/libxcrypt/libxcrypt-4.4.38.ebuild    | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)