Bug 950186 – sys-auth/pambase-20240128: duplicated lastlog module call in login

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thibaud CANALE 2025-02-23 13:32:15 UTC]

It displays two entries when authenticating through TTY, the last having the current time so pointless.
Also it is not discarded in minimal configuration.

First introduced in commit ae72ea9e54b7f5035fb6b3120c0e75e79860e819, tag pambase-20140313.
Then imported for rework in commit 405452a4aa5a9ae06169b0aa1c394a4cae9c1c5c.

[Comment 1 Larry the Git Cow 2025-02-23 23:46:10 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pambase.git/commit/?id=b5cd9e04a00beec05e7c01c75073e24bda0f0655

commit b5cd9e04a00beec05e7c01c75073e24bda0f0655
Author:     Thibaud CANALE <[e-mail]>
AuthorDate: 2025-02-23 09:36:35 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-02-23 23:45:57 +0000

    login.tpl: remove duplicated lastlog module call
    
    It displays two entries when authenticating through TTY, the last having
    the current time so pointless.
    Also it is not discarded in minimal configuration.
    
    First introduced in commit ae72ea9e54b7f5035fb6b3120c0e75e79860e819, tag pambase-20140313.
    Then imported for rework in commit 405452a4aa5a9ae06169b0aa1c394a4cae9c1c5c.
    
    Bug: https://bugs.gentoo.org/950186
    Signed-off-by: Thibaud CANALE <[e-mail]>
    Closes: https://github.com/gentoo/pambase/pull/21
    Signed-off-by: Sam James <[e-mail]>

 templates/login.tpl          | 1 -
 tests/rendered/custom/login  | 1 -
 tests/rendered/default/login | 1 -
 tests/rendered/minimal/login | 1 -
 4 files changed, 4 deletions(-)

[Comment 2 Larry the Git Cow 2025-02-23 23:53:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7da1e379d6b9b162aee9326066408d052366fdfd

commit 7da1e379d6b9b162aee9326066408d052366fdfd
Author:     Sam James <[e-mail]>
AuthorDate: 2025-02-23 23:49:27 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-02-23 23:52:32 +0000

    sys-auth/pambase: add 20250223
    
    Mike Gilbert (2):
          Make pam_shells optional
          tox: allowlist_externals = diff
    
    Thibaud CANALE (1):
          login.tpl: remove duplicated lastlog module call
    
    Bug: https://bugs.gentoo.org/939892
    Closes: https://bugs.gentoo.org/950186
    Signed-off-by: Sam James <[e-mail]>

 sys-auth/pambase/Manifest                |   1 +
 sys-auth/pambase/pambase-20250223.ebuild | 118 +++++++++++++++++++++++++++++++
 2 files changed, 119 insertions(+)