Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949960 - x11-terms/aterm: tree clean request
Summary: x11-terms/aterm: tree clean request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ilia Mirkin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-19 07:39 UTC by NHO
Modified: 2025-05-02 17:33 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description NHO 2025-02-19 07:39:58 UTC
This is twenty years dead terminal emulator that has multiple build bugs:
https://bugs.gentoo.org/882169
https://bugs.gentoo.org/894620
https://bugs.gentoo.org/712894
https://bugs.gentoo.org/932284
https://bugs.gentoo.org/920478
https://bugs.gentoo.org/907400
https://bugs.gentoo.org/943891
At least three of them are trivially fixable, but:

The package itself, with it's build system and it's code, fundamentally broken, both in build system that uses sed to generate headers, and in code, that assumes 32-bit only world:

Bool 
read_32bit_property (Window w, Atom property, CARD32* trg)
{
        Bool          res = False;

        if (w != None && property != None && trg)
        {
                Atom          actual_type;
                int           actual_format;
        unsigned long bytes_after;
                union 
                {
                        unsigned char *uc_ptr ;
                        long              *long_ptr ;
                }data;
                unsigned long nitems;

                data.long_ptr = NULL ;
                res =
                        (XGetWindowProperty
                         (Xdisplay, w, property, 0, 1, False, AnyPropertyType, &actual_type,
                          &actual_format, &nitems, &bytes_after, &data.uc_ptr) == 0);

                /* checking property sanity */
                res = (res && nitems > 0 && actual_format == 32);

                if (res)
                        trg[0] = data.long_ptr[0];
                if (data.long_ptr && nitems > 0)
                        XFree (data.long_ptr);
        }
        return res;
}

This is a function that gets Xorg properties, checks that they are 32 byte long and tries to put them into internal variables. There's no read_64bit_property. Properties it's often tries to get are pointers. It tries to do this on 64bit system.
This and analogous functions are used everywhere.

There are also modern, maintained, visually pretty terminal emulators with transparent background.
Comment 1 NHO 2025-02-19 07:49:26 UTC
no, USE=xgetdefault doesn't switch that crazy accessor off.
Comment 2 NHO 2025-02-19 07:52:29 UTC
USE=xgetdefault adds -std=gnu89 to compiler flags.

This is crazy, please drop this.
Comment 3 Matt Turner gentoo-dev 2025-04-02 01:31:42 UTC
Yes, I think we should treeclean aterm. I kept it around at imirkin's request, but he hasn't addressed bugs in a timely manner. Since I know of no other users, I think he should just keep an ebuild in a local overlay.
Comment 4 Larry the Git Cow gentoo-dev 2025-04-02 01:38:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a873f6f286ca6b09a5756c3a921991070717d225

commit a873f6f286ca6b09a5756c3a921991070717d225
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2025-04-02 01:38:02 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2025-04-02 01:38:02 +0000

    package.mask: Last rite x11-terms/aterm
    
    Bug: https://bugs.gentoo.org/949960
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 5 Ilia Mirkin 2025-04-02 01:53:09 UTC
(In reply to Matt Turner from comment #3)
> Yes, I think we should treeclean aterm. I kept it around at imirkin's
> request, but he hasn't addressed bugs in a timely manner. Since I know of no
> other users, I think he should just keep an ebuild in a local overlay.

Seems fair enough. The bugs are trivially fixable/ignorable, but carrying dubious package patches in gentoo portage is probably not the right approach either. (Like that pointer size mismatch thing.)

I'll keep it locally, since I'm probably the last user of aterm.
Comment 6 Zdravko Spoljar 2025-04-04 15:55:23 UTC
(In reply to Ilia Mirkin from comment #5)
> (In reply to Matt Turner from comment #3)
> > Yes, I think we should treeclean aterm. I kept it around at imirkin's
> > request, but he hasn't addressed bugs in a timely manner. Since I know of no
> > other users, I think he should just keep an ebuild in a local overlay.
> 
> Seems fair enough. The bugs are trivially fixable/ignorable, but carrying
> dubious package patches in gentoo portage is probably not the right approach
> either. (Like that pointer size mismatch thing.)
> 
> I'll keep it locally, since I'm probably the last user of aterm.

just for info, you are not last user, i use aterm too. i was long-term xterm user, but since there is some problems with xterm+hwaccel, i found aterm as acceptable replacement. 
if moved it out portage, i will keep it local too.
Comment 7 Larry the Git Cow gentoo-dev 2025-05-02 17:33:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8a2b033677844be434eb3751d1aaae05e31cbb3

commit f8a2b033677844be434eb3751d1aaae05e31cbb3
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2025-05-02 17:29:43 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2025-05-02 17:33:05 +0000

    x11-terms/aterm: Delete
    
    Closes: https://bugs.gentoo.org/949960
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask                              |  6 --
 x11-terms/aterm/Manifest                           |  1 -
 x11-terms/aterm/aterm-1.0.1-r6.ebuild              | 92 ----------------------
 .../files/aterm-1.0.1-configure-clang16.patch      | 23 ------
 x11-terms/aterm/files/aterm-1.0.1-deadkeys.patch   | 35 --------
 .../files/aterm-1.0.1-display-security-issue.patch | 24 ------
 x11-terms/aterm/files/aterm-1.0.1-dpy.patch        | 28 -------
 .../aterm/files/aterm-1.0.1-remove-streams.patch   | 36 ---------
 x11-terms/aterm/metadata.xml                       | 21 -----
 9 files changed, 266 deletions(-)