Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949856 - [guru] sci-misc/llama-cpp-0_pre4576 Add ROCm 6.3 HIP support as a backend
Summary: [guru] sci-misc/llama-cpp-0_pre4576 Add ROCm 6.3 HIP support as a backend
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergey 'L29Ah' Alirzaev
URL: https://github.com/ggml-org/llama.cpp...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-17 06:11 UTC by MrSnivvel
Modified: 2025-02-21 12:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Adds ROCm 6.3 HIP support to llama-cpp-0_pre4576.ebuild in the tree (llama.cpp-ebuild-rocm-support.patch,1.31 KB, patch)
2025-02-17 06:12 UTC, MrSnivvel
Details | Diff
Adds ROCm 6.3 HIP support to llama-cpp-0_pre4576.ebuild in the tree (llama.cpp-ebuild-rocm-support.patch,1.09 KB, patch)
2025-02-18 20:41 UTC, MrSnivvel
Details | Diff
Add 'hip' to the USE flag description in the metadata.xml (llama.cpp-metadata-xml-rocm-support.patch,427 bytes, patch)
2025-02-18 20:42 UTC, MrSnivvel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MrSnivvel 2025-02-17 06:11:08 UTC
Patch to add ROCm 6.3 HIP support to llama-cpp

Reproducible: Always
Comment 1 MrSnivvel 2025-02-17 06:12:36 UTC
Created attachment 919128 [details, diff]
Adds ROCm 6.3 HIP support to llama-cpp-0_pre4576.ebuild in the tree
Comment 2 MrSnivvel 2025-02-18 19:25:51 UTC
Adding package's maintainer.
Comment 3 Sergey 'L29Ah' Alirzaev 2025-02-18 19:33:44 UTC
I have nowhere to test it:

- dev-util/hip-6.3.2::gentoo USE="hip -debug -doc (-opencl) -test" ABI_X86="(64)" LLVM_SLOT="19" VIDEO_CARDS="-amdgpu -nvidia"

  The following REQUIRED_USE flag constraints are unsatisfied:
    exactly-one-of ( video_cards_amdgpu video_cards_nvidia )

I can blindly accept it though if it works for you, sans some changes:

* `-DCMAKE_BUILD_TYPE=Release` seems out of scope and violates our debugging symbols policy at least
* `pkgcheck scan` demonstrates multiple issues with your patch, you should fix them
Comment 4 MrSnivvel 2025-02-18 20:41:53 UTC
Created attachment 919350 [details, diff]
Adds ROCm 6.3 HIP support to llama-cpp-0_pre4576.ebuild in the tree

Updated ebuild patch
Comment 5 MrSnivvel 2025-02-18 20:42:58 UTC
Created attachment 919351 [details, diff]
Add 'hip' to the USE flag description in the metadata.xml
Comment 6 Larry the Git Cow gentoo-dev 2025-02-21 12:04:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e01288b79918003e5e4a26936c4ce46aa746e5b3

commit e01288b79918003e5e4a26936c4ce46aa746e5b3
Author:     Sergey Alirzaev <l29ah@riseup.net>
AuthorDate: 2025-02-20 14:57:54 +0000
Commit:     Sergey Alirzaev <l29ah@riseup.net>
CommitDate: 2025-02-20 14:57:54 +0000

    sci-misc/llama-cpp: Add ROCm 6.3 HIP support
    
    Closes: https://bugs.gentoo.org/949856
    Signed-off-by: Sergey Alirzaev <l29ah@riseup.net>

 sci-misc/llama-cpp/llama-cpp-0_pre4576.ebuild | 35 +++++++++++++++++++++++++--
 sci-misc/llama-cpp/llama-cpp-9999.ebuild      | 35 +++++++++++++++++++++++++--
 sci-misc/llama-cpp/metadata.xml               |  1 +
 3 files changed, 67 insertions(+), 4 deletions(-)