Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949836 - dev-ada/gprbuild: gprbuild shows incorrect version
Summary: dev-ada/gprbuild: gprbuild shows incorrect version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux ADA team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2025-02-16 12:51 UTC by Luke A. Guest
Modified: 2025-02-16 20:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch version and release type (0001-Fix-version-number-and-release-type.patch,1004 bytes, patch)
2025-02-16 13:03 UTC, Luke A. Guest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke A. Guest 2025-02-16 12:51:52 UTC
See this thread https://forum.ada-lang.io/t/why-is-gprbuild-on-github-labelled-25-0-0/1817/5

Seems, they patch the source with the version, don't know about the date, which is incredibly stupid.

Both the 24.x and 25.x ebuilds should patch the version number.

So, from https://github.com/AdaCore/gprbuild/blob/8afff024f50e3f8bb73bb726e6e2890b141369d1/gpr/src/gpr-version.ads#L27-L29:

The following needs to be patched:

   Gpr_Version : constant String := "18.0w";

   Date : constant String := "19940713";

   Current_Year : constant String := "2016";

   Build_Type : constant Gnat_Build_Type := Gnatpro;

The last to FSF.
Comment 1 Luke A. Guest 2025-02-16 13:03:48 UTC
Created attachment 919062 [details, diff]
Patch version and release type

With my patch:

# gprbuild --version
GPRBUILD 25.0 (19940713) (x86_64-pc-linux-gnu)
Copyright (C) 2004-2016, AdaCore
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

The date still needs correcting, I've no clue what that should be.
Comment 2 Luke A. Guest 2025-02-16 13:04:17 UTC
24 needs a patch too.
Comment 3 Larry the Git Cow gentoo-dev 2025-02-16 20:53:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23f78eb8281afb19bc5389a984f16993c269f985

commit 23f78eb8281afb19bc5389a984f16993c269f985
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2025-02-16 20:52:20 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2025-02-16 20:53:06 +0000

    dev-ada/gprbuild: Fix version in --version
    
    Closes: https://bugs.gentoo.org/949836
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 .../{gprbuild-24.0.0-r2.ebuild => gprbuild-24.0.0-r3.ebuild}       | 7 ++++++-
 .../{gprbuild-25.0.0-r2.ebuild => gprbuild-25.0.0-r3.ebuild}       | 5 +++++
 2 files changed, 11 insertions(+), 1 deletion(-)