Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949373 - cross-aarch64-linux-gnu/binutils-2.44: patch does not apply
Summary: cross-aarch64-linux-gnu/binutils-2.44: patch does not apply
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-06 16:36 UTC by Kacper Słomiński
Modified: 2025-02-06 17:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cross-aarch64-linux-gnu/binutils-2.44 build.log (build.log,3.71 KB, text/x-log)
2025-02-06 16:36 UTC, Kacper Słomiński
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Słomiński 2025-02-06 16:36:47 UTC
Created attachment 918266 [details]
cross-aarch64-linux-gnu/binutils-2.44 build.log

Reject file is as follows:

--- ld/ldelf.c
+++ ld/ldelf.c
@@ -1168,11 +1168,7 @@ ldelf_handle_dt_needed (struct elf_link_hash_table *htab,
          len = strlen (l->name);
          for (search = search_head; search != NULL; search = search->next)
            {
-             char *filename;
-
-             if (search->source != search_dir_linker_script)
-               continue;
-             filename = (char *) xmalloc (strlen (search->name) + len + 2);
+             char *filename = (char *) xmalloc (strlen (search->name) + len + 2);
              sprintf (filename, "%s/%s", search->name, l->name);
              nn.name = filename;
              if (ldelf_try_needed (&nn, force, is_linux))

Looking at bug 937381 and the current source code, it looks like the changes in 2.43 were reverted for 2.44?
Comment 1 Larry the Git Cow gentoo-dev 2025-02-06 17:19:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30c561fe7e6692837e7770ede4358138ed8829b8

commit 30c561fe7e6692837e7770ede4358138ed8829b8
Author:     Kacper Słomiński <kacper.slominski72@gmail.com>
AuthorDate: 2025-02-06 17:11:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-06 17:18:50 +0000

    sys-devel/binutils: Switch to previous patches for 2.44
    
    The change that necessitated the new patches in 2.43 seems to have been
    reverted in 2.44.
    
    Closes: https://bugs.gentoo.org/949373
    Signed-off-by: Kacper Słomiński <kacper.slominski72@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40471
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/binutils/binutils-2.44.9999.ebuild | 4 ++--
 sys-devel/binutils/binutils-2.44.ebuild      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)