Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949031 - mail-filter/opensmtpd-filter-dkimsign: USE flag missing for ed25519 support (feature always disabled)
Summary: mail-filter/opensmtpd-filter-dkimsign: USE flag missing for ed25519 support (...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-29 21:45 UTC by betarays
Modified: 2025-02-24 04:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add ed25519 support as a USE flag (file_949031.txt,705 bytes, patch)
2025-01-29 21:45 UTC, betarays
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description betarays 2025-01-29 21:45:22 UTC
Created attachment 917885 [details, diff]
Patch to add ed25519 support as a USE flag

The source code (see main.c and Makefile.gnu) use #ifdef HAVE_ED25519 to enable ed25519 support, but the current package doesn’t allow compiling with it.
I added a simple patch that I tested locally to fix the issue, but feel free to improve it.
Comment 1 Mike Gilbert gentoo-dev 2025-01-29 22:09:35 UTC
dev-libs/openssl *enables* ed2559 support unconditionally, so it seems reasonable to do the same here (no USE flag).
Comment 2 Larry the Git Cow gentoo-dev 2025-02-15 13:59:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8fcd2710762948cc3f8ad1b060ec86a43e6c35e6

commit 8fcd2710762948cc3f8ad1b060ec86a43e6c35e6
Author:     Cédric Krier <cedk@gentoo.org>
AuthorDate: 2025-02-15 13:58:06 +0000
Commit:     Cédric Krier <cedk@gentoo.org>
CommitDate: 2025-02-15 13:59:06 +0000

    mail-filter/opensmtpd-filter-dkimsign: support ed25519
    
    Closes: https://bugs.gentoo.org/949031
    Signed-off-by: Cédric Krier <cedk@gentoo.org>

 .../opensmtpd-filter-dkimsign-0.6-ed25519.patch    | 85 ++++++++++++++++++++++
 ...ild => opensmtpd-filter-dkimsign-0.6-r1.ebuild} |  5 +-
 2 files changed, 89 insertions(+), 1 deletion(-)
Comment 3 betarays 2025-02-23 21:27:09 UTC
It seems mail-filter/opensmtpd-filter-dkimsign-0.6-r1 doesn’t properly enable ed25519 support: while my example ebuild works, after compiling 0.6-r1 on my machine and starting OpenSTMPD, I get:

dkimsign_ed25519: invalid algorithm
warn: lost processor: dkimsign_ed25519 exited abnormally
Exiting

I’m not sure why that might be happening.
Comment 4 betarays 2025-02-23 21:38:37 UTC
Compiling manually with the patch works, compiling without it makes filter-dkimsign return the same error.
Maybe the ebuild doesn’t call eapply?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-02-24 04:36:47 UTC
The ebuild calls 'eapply_user' in src_prepare rather than 'default' which would do both "eapply on all PATCHES" *and* "eapply_user".
Comment 6 Larry the Git Cow gentoo-dev 2025-02-24 04:39:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d94f3a89b3f491b078a58f29ba9445d78a06433

commit 5d94f3a89b3f491b078a58f29ba9445d78a06433
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-02-24 04:37:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-24 04:38:56 +0000

    mail-filter/opensmtpd-filter-dkimsign: fix src_prepare (and patch)
    
    The ebuild calls 'eapply_user' in src_prepare rather than 'default'
    which would do both "eapply on all PATCHES" *and* "eapply_user".
    
    The filename in the ebuild also wasn't right.
    
    Unfortunately, the patch also couldn't then apply because it has
    the wrong patch-level, so fixed that too by making it -p1-compliant.
    
    Closes: https://bugs.gentoo.org/949031
    Fixes: 8fcd2710762948cc3f8ad1b060ec86a43e6c35e6
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/opensmtpd-filter-dkimsign-0.6-ed25519.patch        | 12 ++++++------
 ...0.6-r1.ebuild => opensmtpd-filter-dkimsign-0.6-r2.ebuild} |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)