Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948947 - sys-kernel/gentoo-kernel-6.12.0 - net-wireless/broadcom-sta no longer works due to CONFIG_LIB80211 unset
Summary: sys-kernel/gentoo-kernel-6.12.0 - net-wireless/broadcom-sta no longer works d...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Distribution Kernel Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-28 10:00 UTC by immolo
Modified: 2025-02-24 09:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
broadcom-wl-fix-linux-6.13.patch (broadcom-wl-fix-linux-6.13.patch,1.13 KB, patch)
2025-01-28 13:43 UTC, immolo
Details | Diff
broadcom-sta-6.30.223.271-r8.ebuild (file_948947.txt,3.92 KB, text/plain)
2025-02-11 05:27 UTC, Sam Petch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description immolo 2025-01-28 10:00:49 UTC
Starting with the 6.12 dist-kernel we no longer support the broadcom-sta driver out the box.

This is due to Fedora removing CONFIG_RTLLIB which in turn unsets CONFIG_LIB80211.

I've been unable to find out why Fedora has unset this, so for now recording as a bug.

No build log provided as it doesn't provide any useful error and instead found the cause and solution by testing every module the ebuild checks for.
Comment 1 immolo 2025-01-28 10:59:30 UTC
It is also possible to set CONFIG_LIB80211 by setting CONFIG_IPW2100 or CONFIG_IPW2200 as well, however I can't find a time when we ever set this in the kernel.
Comment 2 immolo 2025-01-28 13:43:36 UTC
Created attachment 917713 [details, diff]
broadcom-wl-fix-linux-6.13.patch

Looks like the lib80211 code is being merged into libiw with 6.13 which could be the cause of the drop from the defconfig.

Someone with access with a broadcom wifi card will need to take it from here however the 6.13 patch should allow to bypass the need to use lib80211 but I'm shooting in the dark at this point.
Comment 3 immolo 2025-01-28 13:45:22 UTC
lib80211 merge into libiw - https://github.com/torvalds/linux/commit/71e0ad345163c150ea15434b37036b0678d5f6f4
Comment 4 Sam Petch 2025-02-11 05:19:20 UTC
(In reply to immolo from comment #2)
> Created attachment 917713 [details, diff] [details, diff]
> broadcom-wl-fix-linux-6.13.patch
> 
> Looks like the lib80211 code is being merged into libiw with 6.13 which
> could be the cause of the drop from the defconfig.
> 
> Someone with access with a broadcom wifi card will need to take it from here
> however the 6.13 patch should allow to bypass the need to use lib80211 but
> I'm shooting in the dark at this point.

I own a Macbook Pro 2012 (A1278) which uses this wifi card, and I've tested the provided "broadcom-wl-fix-linux-6.13.patch" on this machine. 

When applied alongside the patch from PR https://github.com/gentoo/gentoo/pull/40391, it works and successfully removes any dependency on CONFIG_IPW2100 or CONFIG_IPW2200 for this driver on kernels 6.12 and 6.13.
Comment 5 Sam Petch 2025-02-11 05:27:38 UTC
Created attachment 918631 [details]
broadcom-sta-6.30.223.271-r8.ebuild
Comment 6 Sam Petch 2025-02-11 05:28:54 UTC
(In reply to Sam Petch from comment #4)
> (In reply to immolo from comment #2)
> > Created attachment 917713 [details, diff] [details, diff] [details, diff]
> > broadcom-wl-fix-linux-6.13.patch
> > 
> > Looks like the lib80211 code is being merged into libiw with 6.13 which
> > could be the cause of the drop from the defconfig.
> > 
> > Someone with access with a broadcom wifi card will need to take it from here
> > however the 6.13 patch should allow to bypass the need to use lib80211 but
> > I'm shooting in the dark at this point.
> 
> I own a Macbook Pro 2012 (A1278) which uses this wifi card, and I've tested
> the provided "broadcom-wl-fix-linux-6.13.patch" on this machine. 
> 
> When applied alongside the patch from PR
> https://github.com/gentoo/gentoo/pull/40391, it works and successfully
> removes any dependency on CONFIG_IPW2100 or CONFIG_IPW2200 for this driver
> on kernels 6.12 and 6.13.

Here is the updated ebuild I used to build the package.  I needed to comment out the checks for CONFIG_IPW2100, CONFIG_IPW2200 and LIB80211_CRYPT_TKIP to get it to unpack, plus change the corresponding CONFIG_CHECK2.
Comment 7 immolo 2025-02-11 05:33:00 UTC
Could you please add a new config check for 6.12+ which reflects these changes and add it to your PR at https://github.com/gentoo/gentoo/pull/40391
Comment 8 Sam Petch 2025-02-11 06:24:35 UTC
Yes, I can do that.
Comment 9 immolo 2025-02-11 06:55:19 UTC
Thank you! Please remember to include that it closes down this bug as well like you did for the other one.
Comment 10 Larry the Git Cow gentoo-dev 2025-02-24 09:26:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e20d1bb6aceb42070277eb784f1462a082b57ba9

commit e20d1bb6aceb42070277eb784f1462a082b57ba9
Author:     Sam Petch <111785134+spetch0x5F@users.noreply.github.com>
AuthorDate: 2025-02-12 06:17:32 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2025-02-24 09:26:19 +0000

    net-wireless/broadcom-sta: handle new headers
    
    Handle new header name in kernels >=6.12, handle 6.13 lib80211 code
    merge into libiw and fix pointer mismatch compiler error for 6.14
    
    [flow: adjust commit message]
    
    Closes: https://bugs.gentoo.org/947928
    Closes: https://bugs.gentoo.org/948947
    Closes: https://github.com/gentoo/gentoo/pull/40391
    Signed-off-by: Sam Petch <111785134+spetch0x5F@users.noreply.github.com>
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 ....ebuild => broadcom-sta-6.30.223.271-r8.ebuild} | 10 ++++--
 .../broadcom-sta/files/001-null-pointer-fix.patch  | 10 ++----
 net-wireless/broadcom-sta/files/002-rdtscl.patch   |  5 ++-
 net-wireless/broadcom-sta/files/003-linux47.patch  |  4 +--
 net-wireless/broadcom-sta/files/004-linux48.patch  |  6 ----
 net-wireless/broadcom-sta/files/006-linux411.patch |  2 --
 net-wireless/broadcom-sta/files/007-linux412.patch |  6 ----
 net-wireless/broadcom-sta/files/008-linux415.patch |  4 +--
 .../files/009-fix_mac_profile_discrepancy.patch    |  4 +--
 net-wireless/broadcom-sta/files/010-linux56.patch  |  4 ---
 net-wireless/broadcom-sta/files/011-linux59.patch  | 18 ----------
 net-wireless/broadcom-sta/files/012-linux517.patch |  6 ----
 net-wireless/broadcom-sta/files/013-linux518.patch |  5 ++-
 net-wireless/broadcom-sta/files/014-linux414.patch |  6 ----
 net-wireless/broadcom-sta/files/015-linux600.patch |  6 ----
 net-wireless/broadcom-sta/files/016-linux601.patch |  5 ++-
 .../files/017-handle-new-header-name-6.12.patch    | 33 ++++++++++++++++++
 .../files/018-broadcom-wl-fix-linux-6.13.patch     | 27 +++++++++++++++
 .../files/019-broadcom-wl-fix-linux-6.14.patch     | 40 ++++++++++++++++++++++
 19 files changed, 122 insertions(+), 79 deletions(-)