Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948891 - sys-cluster/knem-1.1.4_p20250126 neither linux-mod-r1_src_install nor modules_post_process were used
Summary: sys-cluster/knem-1.1.4_p20250126 neither linux-mod-r1_src_install nor modules...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey Shvetsov
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-27 07:59 UTC by Agostino Sarubbo
Modified: 2025-02-01 02:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,71.88 KB, text/plain)
2025-01-27 07:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2025-01-27 07:59:26 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-cluster/knem-1.1.4_p20250126 neither linux-mod-r1_src_install nor modules_post_process were used.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0074
Comment 1 Agostino Sarubbo gentoo-dev 2025-01-27 07:59:27 UTC
Created attachment 917589 [details]
build.log

build log and emerge --info
Comment 2 Mike Pagano gentoo-dev 2025-01-28 23:01:14 UTC
Not sure what this is, as src_install has:

src_install() {
    default
    if use modules; then
        cd "${S}/driver/linux"
        linux-mod-r1_src_install
    fi

    # Drop funny unneeded stuff
    rm "${ED}/usr/sbin/knem_local_install" || die
    rmdir "${ED}/usr/sbin" || die
    # install udev rules
    udev_dorules "${FILESDIR}/45-knem.rules"
    rm "${ED}/etc/10-knem.rules" || die
}


Nothing really useful from the link to the wiki.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-30 10:03:20 UTC
I think if modules are optional, you need to set MODULES_OPTIONAL_IUSE, otherwise the eclass has sanity checks to see if calls are missing.

Right now, if USE=-modules, the eclass still gets its pkg_setup called and so on, then in pkg_postinst, the sanity check says "hey, I got inherited, but you didn't call some of my phases". You can fix that by guarding the pkg_setup etc use, or better, just delete modules from IUSE and set MODULES_OPTIONAL_IUSE="+modules" instead before inherit which handles all that for you.
Comment 4 Mike Pagano gentoo-dev 2025-01-30 13:42:01 UTC
Thank-you, can we update the Wiki with some helpful text around this error?

Since currently it has nothing. I'm willing to help.
Comment 5 Larry the Git Cow gentoo-dev 2025-01-31 23:30:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fbf8f2ad18312079251191c4dbd30b71a789adc

commit 5fbf8f2ad18312079251191c4dbd30b71a789adc
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2025-01-31 23:30:04 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2025-01-31 23:30:04 +0000

    sys-cluster/knem: Add MODULES_OPTIONAL_IUSE support
    
    Closes: https://bugs.gentoo.org/948891
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 sys-cluster/knem/knem-1.1.4_p20250126.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 6 Ionen Wolkens gentoo-dev 2025-02-01 02:27:22 UTC
By the way, when doing IUSE=+modules you do not need ebuild logic around it

aka, linux-mod-r1_src_compile+install and others are a no-op when USE=modules is not set
Comment 7 Ionen Wolkens gentoo-dev 2025-02-01 02:30:07 UTC
Also, the "cd" should be avoidable if modlist is configured with the path.