Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948576 - dev-libs/zziplib should depend on SDL2
Summary: dev-libs/zziplib should depend on SDL2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-22 11:14 UTC by Mike Limansky
Modified: 2025-01-23 00:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Limansky 2025-01-22 11:14:44 UTC
According to sources https://github.com/gdraheim/zziplib/blob/v0.13.78/SDL/CMakeLists.txt#L28 zziplib sdl module uses sdl2, however there is sdl1 dependency in the ebuild.

You can also observe it in the build log:

[63/69] : && /usr/bin/x86_64-pc-linux-gnu-gcc -march=alderlake -mabm -mno-cldemote -mno-kl -mno-pconfig -mno-sgx -mno-widekl -mshstk --param=l1-cache-line-size=64 --param=l1-cache-size=48 --param=l2-cache-size=25600 -O2 -pipe -fno-strict-aliasing -Wl,-O1 -
Wl,--as-needed -Wl,-z,pack-relative-relocs    -rdynamic SDL/CMakeFiles/zzcatsdl.dir/SDL_rwops_zzip.c.o SDL/CMakeFiles/zzcatsdl.dir/SDL_rwops_zzcat.c.o -o SDL/zzcatsdl  -Wl,-rpath,/var/tmp/portage/dev-libs/zziplib-0.13.78/work/zziplib-0.13.78_build/zzip  zz
ip/libzzip.so.13.0.78  -lSDL2  /usr/lib64/libz.so  /usr/lib64/libz.so && :

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-23 00:12:13 UTC
Looks like it's been sdl2 from the start, too: https://github.com/gdraheim/zziplib/commit/d2e7c6d99ea15a7571ee20e632697a998ec41a4e.
Comment 2 Larry the Git Cow gentoo-dev 2025-01-23 00:13:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f8563d0eddd72aaef4f3cadf77664ea8744a41f

commit 8f8563d0eddd72aaef4f3cadf77664ea8744a41f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-01-23 00:12:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-23 00:12:37 +0000

    dev-libs/zziplib: fix libsdl(2) dep
    
    As noted in the bug, the SDL module seems to have always needed libsdl*2*:
    https://github.com/gdraheim/zziplib/commit/d2e7c6d99ea15a7571ee20e632697a998ec41a4e.
    
    Closes: https://bugs.gentoo.org/948576
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/zziplib/{zziplib-0.13.78.ebuild => zziplib-0.13.78-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)