Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948345 - media-sound/strawberry: loudness useflag is now pointless
Summary: media-sound/strawberry: loudness useflag is now pointless
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-18 11:49 UTC by David Flogeras
Modified: 2025-01-18 22:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Flogeras 2025-01-18 11:49:40 UTC
Recent changes to fix binary packages (https://bugs.gentoo.org/925505) have rendered the loudness useflag pointless as it drags in libebur128 regardless.  Is it optional, and the binary packages need to be more flexible, or is it just a hard dep now?

Reproducible: Always
Comment 1 Miroslav Šulc gentoo-dev 2025-01-18 15:07:58 UTC
so it seems the fix i did is not correct as when building without loudness use flag, strawberry does not link against media-libs/libebur128. so i guess the configuration process should be fixed instead to not check for libebur128 when loudness is disabled.
Comment 2 Larry the Git Cow gentoo-dev 2025-01-18 15:12:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e737b5fa76b5fd261215e1397ad6344c64193d9

commit 7e737b5fa76b5fd261215e1397ad6344c64193d9
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2025-01-18 15:12:15 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2025-01-18 15:12:24 +0000

    media-sound/strawberry: dropped duplicate dependency
    
    Closes: https://bugs.gentoo.org/948345
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/strawberry/strawberry-1.2.2-r1.ebuild | 1 -
 media-sound/strawberry/strawberry-1.2.5.ebuild    | 1 -
 media-sound/strawberry/strawberry-9999.ebuild     | 1 -
 3 files changed, 3 deletions(-)
Comment 3 Miroslav Šulc gentoo-dev 2025-01-18 15:12:55 UTC
i reverted my "fix", it's probably not broken anymore...
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-18 17:04:11 UTC
(In reply to Miroslav Šulc from comment #3)
> i reverted my "fix", it's probably not broken anymore...

I'm a bit confused now. 

https://github.com/strawberrymusicplayer/strawberry/blob/ae89ca8123267547a950c994f751e4d3b7605b88/CMakeLists.txt#L193 says to me it *is* still automagic. So I think this reintroduces bug 925505.

You should be able to verify that by looking at ELF NEEDED (iwdevtools this for you) with USE=-loudness but with libebur128 installed.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-18 22:36:36 UTC
I'll reopen the other bug so we don't lose track.