Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948139 - dev-libs/libtpms-0.10.0 fails tests: FAIL: nvram_offsets
Summary: dev-libs/libtpms-0.10.0 fails tests: FAIL: nvram_offsets
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Christopher Byrne
URL:
Whiteboard:
Keywords: PATCH, PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2025-01-15 07:53 UTC by Agostino Sarubbo
Modified: 2025-02-25 04:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,495.86 KB, text/plain)
2025-01-15 07:53 UTC, Agostino Sarubbo
Details
1-test-suite.log (1-test-suite.log,1.02 KB, text/plain)
2025-01-15 07:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2025-01-15 07:53:26 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/libtpms-0.10.0 fails tests.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-15-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-15)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2025-01-15 07:53:27 UTC
Created attachment 916572 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2025-01-15 07:53:28 UTC
Created attachment 916573 [details]
1-test-suite.log

1-test-suite.log
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-17 12:39:55 UTC
```
FAIL: nvram_offsets
===================

sizeof(OBJECT) does not have expected size of 2608 bytesbut 2604 bytes
sizeof(TPMT_PUBLIC) is now 484 bytes;was 356/484 bytes for 2048/3072 bit RSA keys
sizeof(TPMT_SENSITIVE) is now 1096 bytes;was 776/1096 bytes for 2048/3072 bit RSA keys
sizeof(privateExponent_t) is now 864 bytes;was 608/864 bytes for 2048/3072 bit RSA keys
FAIL nvram_offsets (exit status: 1)
```

ago, is this a gcc 15 thing? does it pass with 14?
Comment 4 Agostino Sarubbo gentoo-dev 2025-01-17 12:59:07 UTC
definitely works with gcc-14:

PASS: nvram_offsets
PASS: tpm2_createprimary.sh
PASS: tpm2_cve-2023-1017.sh
PASS: tpm2_cve-2023-1018.sh
PASS: tpm2_pcr_read.sh
PASS: tpm2_setprofile.sh
PASS: tpm2_selftest.sh
PASS: base64decode.sh
PASS: fuzz.sh
============================================================================
Testsuite summary for libtpms 0.10.0
============================================================================
# TOTAL: 9
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/var/tmp/portage/dev-libs/libtpms-0.10.0/work/libtpms-0.10.0/tests'
make[2]: Leaving directory '/var/tmp/portage/dev-libs/libtpms-0.10.0/work/libtpms-0.10.0/tests'
make[1]: Leaving directory '/var/tmp/portage/dev-libs/libtpms-0.10.0/work/libtpms-0.10.0/tests'
make[1]: Entering directory '/var/tmp/portage/dev-libs/libtpms-0.10.0/work/libtpms-0.10.0'
make[1]: Leaving directory '/var/tmp/portage/dev-libs/libtpms-0.10.0/work/libtpms-0.10.0'
>>> Completed testing dev-libs/libtpms-0.10.0
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-17 13:12:02 UTC
Thanks!

Looking...
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-17 13:42:17 UTC
It fails for me with 14+15 if I revert that commit on master.

Anyway, I'll backport the fix.

Maybe it was only broken for 0.10.0 with:

commit a5977d20188d0d96e17553f4442730716682f1c3
Author: Stefan Berger <stefanb@linux.ibm.com>
Date:   Wed Jul 24 11:54:17 2024 -0400

    rev180: Add hierarchy field to OBJECT and use it

    Add new field hierarchy to OBJECT and assign values to it and access it.

    Beyond the sync with upstream we need to also set the hierachy when
    - an older OBJECT is converted to the current OBJECT
    - an OBJECT is unmarshalled

    Remove ObjectGetHierarchy since it is not needed anymore.

    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Comment 8 Agostino Sarubbo gentoo-dev 2025-01-17 13:45:07 UTC
(In reply to Agostino Sarubbo from comment #4)
> definitely works with gcc-14:

I was mistankenly checking on amd64. It fails with gcc-14 too
Comment 9 Larry the Git Cow gentoo-dev 2025-02-25 04:15:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7dffb121b44164c788806b71c16fec40f39754d1

commit 7dffb121b44164c788806b71c16fec40f39754d1
Author:     Christopher Byrne <salah.coronya@gmail.com>
AuthorDate: 2025-02-25 00:36:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-25 04:14:47 +0000

    dev-libs/libtpms: Fix nvram_offsets test on 32-bit platforms
    
    Closes: https://bugs.gentoo.org/948139
    Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40742
    Signed-off-by: Sam James <sam@gentoo.org>

 ...2-Add-padding-to-OBJECT-for-32bit-targets.patch | 32 +++++++++++++
 dev-libs/libtpms/libtpms-0.10.0-r1.ebuild          | 52 ++++++++++++++++++++++
 2 files changed, 84 insertions(+)