Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 947918 - dev-vcs/git-2.48.0 with USE=tk doesn't install gitk anymore
Summary: dev-vcs/git-2.48.0 with USE=tk doesn't install gitk anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2025-01-11 17:40 UTC by shinydoofy
Modified: 2025-01-14 12:24 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch for installing gitk again (restore-gitk-for-2.48.0.patch,995 bytes, patch)
2025-01-11 17:41 UTC, shinydoofy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description shinydoofy 2025-01-11 17:40:56 UTC
After upgrading from 2.47.1 to 2.48.0, /usr/bin/gitk is missing. This was previously the case with USE=tk, but isn't anymore.

Reproducible: Always

Steps to Reproduce:
1. Have =dev-vcs/git-2.47.1 installed
2. Upgrade to =dev/vcs/git-2.48.0
3. Try running `gitk --all` in one of your local repositories to see its history
Actual Results:  
bash: gitk: command not found

Expected Results:  
gitk opens
Comment 1 shinydoofy 2025-01-11 17:41:59 UTC
Created attachment 916336 [details, diff]
Ebuild patch for installing gitk again
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-12 16:54:05 UTC
Thanks!
Comment 3 Larry the Git Cow gentoo-dev 2025-01-12 16:55:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de507853de11a25486bc95aeeafc2cd86e7e92b4

commit de507853de11a25486bc95aeeafc2cd86e7e92b4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-01-12 16:54:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-12 16:54:04 +0000

    dev-vcs/git: restore USE=tk functionality
    
    Closes: https://bugs.gentoo.org/947918
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/git/{git-2.48.0.ebuild => git-2.48.0-r1.ebuild} |  9 ++++++++-
 dev-vcs/git/git-9999-r1.ebuild                          | 13 ++++++++++++-
 dev-vcs/git/git-9999-r2.ebuild                          | 13 ++++++++++++-
 dev-vcs/git/git-9999-r3.ebuild                          | 13 ++++++++++++-
 4 files changed, 44 insertions(+), 4 deletions(-)
Comment 4 Edward Kigwana 2025-01-12 19:10:00 UTC
This is not quite done because 'git gui' is still missing
Comment 5 Yuri Sevatz 2025-01-13 18:13:46 UTC
Afaik the Makefile just calls this "git-gui", in a similar way as your "gitk-git":

https://github.com/git/git/blob/fbe8d3079d4a96aeb4e4529cc93cc0043b759a05/Makefile#L2421

The only thing that appears unique about this is that the Makefile seems to want 'gitexecdir' set.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-14 12:22:20 UTC
(In reply to Yuri Sevatz from comment #5)
> Afaik the Makefile just calls this "git-gui", in a similar way as your
> "gitk-git":
> 
> https://github.com/git/git/blob/fbe8d3079d4a96aeb4e4529cc93cc0043b759a05/
> Makefile#L2421
> 
> The only thing that appears unique about this is that the Makefile seems to
> want 'gitexecdir' set.

I think the default value ends up working out.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-14 12:22:31 UTC
(In reply to Sam James from comment #6)
> (In reply to Yuri Sevatz from comment #5)
> > Afaik the Makefile just calls this "git-gui", in a similar way as your
> > "gitk-git":
> > 
> > https://github.com/git/git/blob/fbe8d3079d4a96aeb4e4529cc93cc0043b759a05/
> > Makefile#L2421
> > 
> > The only thing that appears unique about this is that the Makefile seems to
> > want 'gitexecdir' set.
> 
> I think the default value ends up working out.

(at least with the stuff emake_git sets)
Comment 8 Larry the Git Cow gentoo-dev 2025-01-14 12:24:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93afe80bee15f82d63af89ede15c2c3a4e78f004

commit 93afe80bee15f82d63af89ede15c2c3a4e78f004
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-01-14 12:21:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-14 12:21:52 +0000

    dev-vcs/git: restore git-gui too for USE=tk
    
    Closes: https://bugs.gentoo.org/947918
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/git/{git-2.48.0-r1.ebuild => git-2.48.0-r2.ebuild} | 2 ++
 dev-vcs/git/git-9999-r2.ebuild                             | 2 ++
 dev-vcs/git/git-9999-r3.ebuild                             | 2 ++
 3 files changed, 6 insertions(+)