Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 947505 - app-misc/beep-1.4.12-r1 with USE="filecaps" - no file caps set
Summary: app-misc/beep-1.4.12-r1 with USE="filecaps" - no file caps set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-04 19:47 UTC by Maciej S. Szmigiero
Modified: 2025-01-05 04:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2025-01-04 19:47:10 UTC
app-misc/beep-1.4.12-r1 with USE="filecaps" broke setting file caps on /usr/bin/beep:
> # getcap /usr/bin/beep
> 

If I downgrade to the previous ebuild revision the file caps are set properly:
> # emerge -1v '=app-misc/beep-1.4.12'
> # getcap /usr/bin/beep
> /usr/bin/beep cap_dac_override,cap_sys_tty_config=ep

That's on btrfs root filesystem type btw.
Comment 1 Ionen Wolkens gentoo-dev 2025-01-04 23:29:57 UTC
Thanks, I'll handle it.

CC'ing author/committer of commit just as a for-your-information.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-04 23:37:20 UTC
Thank you!
Comment 3 Larry the Git Cow gentoo-dev 2025-01-04 23:43:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8d7a87420bc34c9c9caadf12b606f5c7313dfb5

commit a8d7a87420bc34c9c9caadf12b606f5c7313dfb5
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2025-01-04 23:21:19 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2025-01-04 23:42:21 +0000

    app-misc/beep: fix fcaps usage & adjust further
    
    This does not run fcaps_pkg_postinst, so the array is never used.
    
    Also:
    1. little reason to use arrays if going to immediately run
       fcaps_pkg_postinst on the next line (same for einstalldocs)
    2. switch to 755 rather than 711, fcaps.eclass switched to allow
       world read in commit f8642f4a3ef06b7b82985c9f770e5cda862adb54
       and I see no no reason to override that default here
    3. drop fperms line, the Makefile does not set a suid-bit and
       defaults to 0755, so it's now redundant
    4. use relative path for fcaps call, let eclass handle EROOT
    5. fwiw drop INSTALL.md+PACKAGING.md, packager-intended docs are not
       interesting for users... also makes the line break at <80 chars :)
    
    Fixes: 01e878219667bf8ce1781f7b74758ecf40ecb80b
    Closes: https://bugs.gentoo.org/947505
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../{beep-1.4.12-r1.ebuild => beep-1.4.12-r2.ebuild}     | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
Comment 4 Zhixu Liu 2025-01-05 04:41:14 UTC
thanks, have no clue how I forget the fcaps call, ...
Comment 5 Zhixu Liu 2025-01-05 04:52:39 UTC
also, the elog in postinst is useful only in case of:
1. USE="-filecaps"
2. USE="filecaps" but fcaps failed to setcap because filesystem has no xattr support. This can be handled only by test the capability of /usr/bin/beep?