Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 947239 - app-text/diffpdf: Port to Qt6 possible or last-rites on the horizon?
Summary: app-text/diffpdf: Port to Qt6 possible or last-rites on the horizon?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Maciej Mrozowski
URL: https://www.qtrac.eu/diffpdf-changes....
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: EAPI7Removal qt5-removal
  Show dependency tree
 
Reported: 2024-12-30 19:13 UTC by Andreas Sturmlechner
Modified: 2025-03-04 23:23 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diffpdf-qt6-wip.patch (diffpdf-qt6-wip.patch,11.06 KB, patch)
2025-03-02 23:07 UTC, Jaak Ristioja
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-12-30 19:13:33 UTC
Current version is extremely outdated and only still in ::gentoo by means of a Qt5-porting patch. What are the chances this will go on to receive a Qt6-porting patch in a similar manner?
Comment 1 Larry the Git Cow gentoo-dev 2025-03-01 22:58:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=918628e20183d14459335438558ef42e8cd55db1

commit 918628e20183d14459335438558ef42e8cd55db1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-03-01 22:44:54 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-03-01 22:58:05 +0000

    profiles: Mask app-text/diffpdf for removal
    
    Bug: https://bugs.gentoo.org/947239
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 2 Jaak Ristioja 2025-03-02 16:07:02 UTC
The package.mask comment mentions a potential GPL violation:

> # Currently packaged version released 12 years ago; dead upstream,
> # possibly GPL violating piece of very expensive software not available
> # to "new" customers in most countries even for a 5-figure USD sum.
> # Bug #947239. Removal on 2025-03-31.
> app-text/diffpdf
However, according to the following page it seems that the author(s) did once provide a GPL2-licensed version of DiffPDF:

  https://www.qtrac.eu/diffpdf-foss.html
  https://web.archive.org/web/20140401180853/http://www.qtrac.eu/diffpdf-foss.html
  http://www.diffpdf.com/diffpdf-foss.html
  https://web.archive.org/web/20220822010455/http://www.qtrac.plus.com/diffpdf-foss.html

That page is also linked from the description of the https://gitlab.com/eang/diffpdf repository, which seems to be a fork. Also, the codebase itself is quite small and doesn't seem expensive at all, and the author(s) seem to be rather strict on licensing issues. So perhaps I misunderstood the package.mask comment or perhaps I'm missing something else, but I feel that the package.mask entry is misleading.

(In reply to Andreas Sturmlechner from comment #0)
> Current version is extremely outdated and only still in ::gentoo by means of
> a Qt5-porting patch. What are the chances this will go on to receive a
> Qt6-porting patch in a similar manner?

This is a rather simple but very useful program. So I think there is hope. :)
Comment 3 Andreas Sturmlechner gentoo-dev 2025-03-02 16:20:00 UTC
Simple, the upstream product in its current state provides no way forward.

Even the fork you cite has had its last activity 4 years ago, so not very promising to me.
Comment 4 Jaak Ristioja 2025-03-02 23:07:44 UTC
Created attachment 920155 [details, diff]
diffpdf-qt6-wip.patch

> This is a rather simple but very useful program. So I think there is hope. :)

Here's an experimental patch to the source code which switches to CMake, and makes DiffPDF build and run with Qt6. It is a work in progress and not much tested. Hopefully I'll have some more time to improve, polish and test it this week...
Comment 5 Larry the Git Cow gentoo-dev 2025-03-04 23:23:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1048ea64af4086c1c667174c3ce1c678e8c58a29

commit 1048ea64af4086c1c667174c3ce1c678e8c58a29
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-03-04 23:19:39 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-03-04 23:19:39 +0000

    app-text/diffpdf: drop 2.1.3-r2
    
    Closes: https://bugs.gentoo.org/947239
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-text/diffpdf/diffpdf-2.1.3-r2.ebuild | 40 --------------------------------
 1 file changed, 40 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=439a6e16a9ecd8d8cfb251aae76f0a1b29bff6b0

commit 439a6e16a9ecd8d8cfb251aae76f0a1b29bff6b0
Author:     Jaak Ristioja <jaak@ristioja.ee>
AuthorDate: 2025-03-04 20:53:40 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-03-04 23:19:59 +0000

    profiles: Drop obsolete app-text/diffpdf last-rite mask
    
    Bug: https://bugs.gentoo.org/947239
    Signed-off-by: Jaak Ristioja <jaak@ristioja.ee>
    Closes: https://github.com/gentoo/gentoo/pull/40894
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 7 -------
 1 file changed, 7 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=beb25dea6ad6f9e2937467cf181336a255e6d047

commit beb25dea6ad6f9e2937467cf181336a255e6d047
Author:     Jaak Ristioja <jaak@ristioja.ee>
AuthorDate: 2025-03-04 20:47:03 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-03-04 23:18:36 +0000

    app-text/diffpdf: add 2.1.3-r3
    
    Patched for Qt6 support and CMake build system, fixed some pkgcheck warnings.
    
    Bug: https://bugs.gentoo.org/947239
    Signed-off-by: Jaak Ristioja <jaak@ristioja.ee>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-text/diffpdf/diffpdf-2.1.3-r3.ebuild       |  37 +++
 app-text/diffpdf/files/diffpdf-2.1.3-qt6.patch | 407 +++++++++++++++++++++++++
 2 files changed, 444 insertions(+)