AFAICT sys-apps/dcfldd doesn't have a testsuite upstream, so src_test doesn't currently achieve anything. If we had a small smoketest to compute a hash for some known test file and compare the result, we may have been able to find bug 930996 sooner when keywording on e.g. ppc64. so, something like (just psuedocode): ``` src_test() { # Just in case upstream add tests in future default # Smoke test for bug #930996 # Borrowed from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114698#c0 expected_cksum=8021973df8498a650e444fd84c705d9168639a246bc6024066e4091b2b450da6 obtained_cksum=$(echo TestInput | ./dclfdd ... | sha256sum | cut ...) [[ ${expected_cksum} != ${obtained_cksum} ]] && die "uh oh" } ```
No objections, would you be alright with adding it to the ebuild yourself?
Sure, happily! (Did you mean to make this bug private?)
(In reply to Sam James from comment #2) > Sure, happily! Cool! > (Did you mean to make this bug private?) No, I didn't notice, thanks for the remark, reverting…
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0b583e63f9c846d1c99359f7f3940e3b209fcf6 commit e0b583e63f9c846d1c99359f7f3940e3b209fcf6 Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2025-01-11 21:53:42 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2025-01-11 21:56:55 +0000 sys-apps/dcfldd: Add simple test to detect miscompilation Closes: https://bugs.gentoo.org/947030 Suggested-by: Sam James <sam@gentoo.org> Signed-off-by: Sebastian Pipping <sping@gentoo.org> sys-apps/dcfldd/dcfldd-1.9.2-r1.ebuild | 53 ++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+)
I have gone forward adding a test myself now. Does it look alright?
Thanks!
