Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946911 - net-im/telegram-desktop-5.5.5: qt6/QtCore/qchar.h:66:2: error: #error This macro has been removed in Qt 6.8.
Summary: net-im/telegram-desktop-5.5.5: qt6/QtCore/qchar.h:66:2: error: #error This ma...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Esteve Varela Colominas
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-12-25 11:59 UTC by Sergey 'L29Ah' Alirzaev
Modified: 2025-01-06 02:05 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,20.96 KB, text/plain)
2024-12-25 11:59 UTC, Sergey 'L29Ah' Alirzaev
Details
build log (build.log,62.06 KB, text/x-log)
2024-12-25 11:59 UTC, Sergey 'L29Ah' Alirzaev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey 'L29Ah' Alirzaev 2024-12-25 11:59:27 UTC
Created attachment 914858 [details]
emerge --info

In file included from /usr/include/qt6/QtCore/qstring.h:14,
                 from /usr/include/qt6/QtCore/qhashfunctions.h:9,
                 from /usr/include/qt6/QtCore/qmap.h:8,
                 from /usr/include/qt6/QtCore/QMap:1,
                 from /var/tmp/portage/net-im/telegram-desktop-5.5.5/work/tdesktop-5.5.5-full/Telegram/ThirdParty/kcoreaddons/src/lib/io/kurlmimedata.h:14,
                 from /var/tmp/portage/net-im/telegram-desktop-5.5.5/work/tdesktop-5.5.5-full/Telegram/ThirdParty/kcoreaddons/src/lib/io/kurlmimedata.cpp:10:
/usr/include/qt6/QtCore/qchar.h:66:2: error: #error This macro has been removed in Qt 6.8.
   66 | #error This macro has been removed in Qt 6.8.
      |  ^~~~~
ninja: build stopped: subcommand failed.
Comment 1 Sergey 'L29Ah' Alirzaev 2024-12-25 11:59:53 UTC
Created attachment 914859 [details]
build log
Comment 2 Yuriy 2024-12-29 10:33:16 UTC
Same problem
Comment 3 Gabi Falk 2024-12-29 12:39:26 UTC
This one is fixed upstream:

https://github.com/telegramdesktop/tdesktop/commit/566f27913714a11f27765dd64301a750bec8871f

$ git describe --contains 566f27913714a11f27765dd64301a750bec8871f
v5.6.2~18
Comment 4 Yixun Lan archtester gentoo-dev 2024-12-29 23:44:47 UTC
(In reply to Gabi Falk from comment #3)
> This one is fixed upstream:
> 
> https://github.com/telegramdesktop/tdesktop/commit/
> 566f27913714a11f27765dd64301a750bec8871f
> 
> $ git describe --contains 566f27913714a11f27765dd64301a750bec8871f
> v5.6.2~18

hi Esteve or others, any reason why not upgrade/stabilize new version? so we don't have to maintain backward patches.. but either way is fine (I'd just leave maintainer to decide)
Comment 5 Sergey 'L29Ah' Alirzaev 2024-12-29 23:45:58 UTC
(In reply to Yixun Lan from comment #4)
> hi Esteve or others, any reason why not upgrade/stabilize new version? so we
> don't have to maintain backward patches.. but either way is fine (I'd just
> leave maintainer to decide)

It is the last version where https://github.com/Layerex/telegram-desktop-patches apply.
Comment 6 Yixun Lan archtester gentoo-dev 2024-12-30 00:12:50 UTC
(In reply to Sergey 'L29Ah' Alirzaev from comment #5)
> (In reply to Yixun Lan from comment #4)
> > hi Esteve or others, any reason why not upgrade/stabilize new version? so we
> > don't have to maintain backward patches.. but either way is fine (I'd just
> > leave maintainer to decide)
> 
> It is the last version where
> https://github.com/Layerex/telegram-desktop-patches apply.

we really can't guarantee the out of tree patches will always work..
Comment 7 Esteve Varela Colominas 2024-12-30 16:43:24 UTC
I've been having trouble keeping up the stabilization of this package, mostly stemming from confusion as to when it's acceptable to ask for stabilization (and staying on top of bug reports etc). If the current stable is broken, it makes a lot of sense to just mark the actually working versions as stable. I don't have the time or energy to backport patches like I did years back...
Comment 8 Timo Ollech 2025-01-01 20:02:52 UTC
(In reply to Sergey 'L29Ah' Alirzaev from comment #5)
> (In reply to Yixun Lan from comment #4)
> > hi Esteve or others, any reason why not upgrade/stabilize new version? so we
> > don't have to maintain backward patches.. but either way is fine (I'd just
> > leave maintainer to decide)
> 
> It is the last version where
> https://github.com/Layerex/telegram-desktop-patches apply.

Hmm, while there are already pull requests to update these patches:
https://github.com/Layerex/telegram-desktop-patches/pulls
Comment 9 Larry the Git Cow gentoo-dev 2025-01-06 02:05:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b6dab9ad240fc6a8484460fa6617777335337118

commit b6dab9ad240fc6a8484460fa6617777335337118
Author:     Esteve Varela Colominas <esteve.varela@gmail.com>
AuthorDate: 2025-01-05 21:37:19 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2025-01-06 02:03:31 +0000

    net-im/telegram-desktop: Drop old
    
    Closes: https://bugs.gentoo.org/942770
    Closes: https://bugs.gentoo.org/940230
    Closes: https://bugs.gentoo.org/943388
    Closes: https://bugs.gentoo.org/946911
    Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 net-im/telegram-desktop/Manifest                   |   2 -
 .../files/tdesktop-5.8.3-webkit-no-wayland.patch   |  16 --
 net-im/telegram-desktop/metadata.xml               |   1 -
 .../telegram-desktop/telegram-desktop-5.5.5.ebuild | 261 ---------------------
 .../telegram-desktop-5.8.3-r1.ebuild               | 243 -------------------
 5 files changed, 523 deletions(-)