Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946881 - games-strategy/naev-0.12.0: configure failure ERROR: Unknown variable "lua"
Summary: games-strategy/naev-0.12.0: configure failure ERROR: Unknown variable "lua"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
: 946979 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-12-24 15:12 UTC by Oliver Freyermuth
Modified: 2024-12-26 23:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Meson log (meson-log.txt,15.04 KB, text/plain)
2024-12-24 15:14 UTC, Oliver Freyermuth
Details
Full build log (games-strategy:naev-0.12.0:20241224-150524.log.gz,2.63 KB, application/gzip)
2024-12-24 15:14 UTC, Oliver Freyermuth
Details
emerge --info (emerge-info,22.77 KB, text/plain)
2024-12-24 15:15 UTC, Oliver Freyermuth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Freyermuth 2024-12-24 15:12:28 UTC
Build fails in the configure stage with:

subprojects/lyaml-6.2.8/meson.build:42:22: ERROR: Unknown variable "lua".



Reproducible: Always




Will attach build log and dedicated meson subproject log.
Comment 1 Oliver Freyermuth 2024-12-24 15:14:13 UTC
Created attachment 914820 [details]
Meson log
Comment 2 Oliver Freyermuth 2024-12-24 15:14:55 UTC
Created attachment 914821 [details]
Full build log
Comment 3 Oliver Freyermuth 2024-12-24 15:15:46 UTC
Created attachment 914822 [details]
emerge --info
Comment 4 Oliver Freyermuth 2024-12-24 15:19:34 UTC
Presumably, this happens with:
LUA_SINGLE_TARGET="lua5-1 -luajit"
as:
https://github.com/naev/naev/blob/28b5a7abcb5ae7a7b23c70a6ccea704c30e73ec6/subprojects/packagefiles/lyaml/meson.build#L38-L46
bails out always if luajit is disabled.
Comment 5 Ionen Wolkens gentoo-dev 2024-12-24 15:23:24 UTC
Yes, I was testing with luajit and forgot to try 5-1 again.

Given upstream has fallback code for bundled luajit, odds are the lua51 path is not tested much.
Comment 6 Ionen Wolkens gentoo-dev 2024-12-24 15:25:47 UTC
(In reply to Ionen Wolkens from comment #5)
> Yes, I was testing with luajit and forgot to try 5-1 again.
> 
> Given upstream has fallback code for bundled luajit, odds are the lua51 path
> is not tested much.
It'd be an easy fix but tempted to just force luajit by default rather than handle this, this is a hardly tested path and lua5-1 is dead (luajit is still supported).
Comment 7 Oliver Freyermuth 2024-12-24 15:29:42 UTC
(In reply to Ionen Wolkens from comment #6)
> (In reply to Ionen Wolkens from comment #5)
> > Yes, I was testing with luajit and forgot to try 5-1 again.
> > 
> > Given upstream has fallback code for bundled luajit, odds are the lua51 path
> > is not tested much.
> It'd be an easy fix but tempted to just force luajit by default rather than
> handle this, this is a hardly tested path and lua5-1 is dead (luajit is
> still supported).

That sounds very reasonable to me. Personally, I have luajit installed anyways vor various other deps, the main reason naev tried to use lua5-1 is due to it being the LUA_SINGLE_TARGET base profile default.
Comment 8 Larry the Git Cow gentoo-dev 2024-12-24 15:46:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5eb679d5cf045fca91bb3552d3647fd0f30f17e

commit f5eb679d5cf045fca91bb3552d3647fd0f30f17e
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2024-12-24 15:43:36 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2024-12-24 15:45:50 +0000

    games-strategy/naev: force luajit for >=0.12
    
    Also lets us drop the selection workaround.
    
    Closes: https://bugs.gentoo.org/946881
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-strategy/naev/naev-0.12.0.ebuild | 8 +++-----
 profiles/base/package.use.force        | 5 +++++
 2 files changed, 8 insertions(+), 5 deletions(-)
Comment 9 Ionen Wolkens gentoo-dev 2024-12-26 23:04:39 UTC
*** Bug 946979 has been marked as a duplicate of this bug. ***