Created attachment 914736 [details] emerge --info Firefox 133.0.3 fails to build for me. (build log posted below)
https://0x0.st/8rrI.log.zst Not sure how to upload this build log, it seems to be too large, and eventually this link will expire.
Created attachment 914737 [details] xaa (first half of compressed log)
Created attachment 914738 [details] xab (second half of compressed log) Use "cat xaa xab > build.log.xz" to cat the files into one, and then decompress like normal.
[20:12] <sam_> I think this is exposed by juippis' fixes to PGO for GCC [20:13] <sam_> then sandbox::Syscall::Call gets cloned using the profile data [20:13] <sam_> and it ends up in a different LTO partition [20:13] <sam_> so, in a way, this is great [20:13] <sam_> it shows PGO is working :D [20:13] <sam_> because it deduced that it's cold
I'm pretty sure https://src.fedoraproject.org/rpms/firefox/blob/rawhide/f/mozilla-1516803.patch will fix it.
I gather from IRC that the rebased patch worked? I guess when I returned the "old approach" in https://gitweb.gentoo.org/repo/gentoo.git/commit/www-client/firefox?id=47d3ff466c8238445180dacff7bc2bba4977285c I also took the older version of that mozilla-1516803.patch along with it, and that needs an update. Weird that I tested firefox[pgo] just fine with gcc and lto, though.
Wait, https://src.fedoraproject.org/rpms/firefox/raw/rawhide/f/mozilla-1516803.patch this bit is identical to what I have in firefox-133-patches-05.tar.xz -> 0015-gcc-lto-pgo-gentoo.patch Could you copypaste the contents of your 0015-gcc-lto-pgo-gentoo.patch or attach the patch here?
Oh, right, this again. Yeah the patch seems malformed due to some copy-paste error and I guess it doesn't get applied. Will test and fix.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5eb5df285e2324f1b16d12cd4ed6ddbc8eb30a9d commit 5eb5df285e2324f1b16d12cd4ed6ddbc8eb30a9d Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2024-12-23 06:40:34 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-12-23 06:43:27 +0000 www-client/firefox: fix a "typo" in 133.0.3's patchset - one part of 0015-gcc-lto-pgo-gentoo.patch didn't apply because it was read as comments due to copy-pasting missing a crucial position line. Closes: https://bugs.gentoo.org/946835 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 2 +- www-client/firefox/firefox-133.0.3.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Thanks all!
