Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946669 - net-libs/nodejs-22.12.0: update paxmarking.patch
Summary: net-libs/nodejs-22.12.0: update paxmarking.patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-12-19 13:25 UTC by Guillaume Ceccarelli
Modified: 2024-12-26 03:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (nodejs-22.12.0-paxmarking.patch,3.19 KB, text/plain)
2024-12-19 13:25 UTC, Guillaume Ceccarelli
Details
portion of build.log demonstrating the build failure (relevant-portion-of-build.log,4.77 KB, text/plain)
2024-12-19 13:26 UTC, Guillaume Ceccarelli
Details
dmesg output giving context to the build failure (relevant-dmesg.log,459 bytes, text/plain)
2024-12-19 13:27 UTC, Guillaume Ceccarelli
Details
emerge --info (emerge-info.log,8.25 KB, text/plain)
2024-12-19 13:28 UTC, Guillaume Ceccarelli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Ceccarelli 2024-12-19 13:25:01 UTC
Created attachment 914358 [details]
Proposed patch

Currently, attempting to emerge nodejs-22.12.0 on a pax-enabled kernel will result in a build failure: node_mksnapshot is killed upon attempting an RWX memory mapping without the proper markings.

There's already a patch to enable building under such a setup, but it needs to be updated, as the related paxmarking in node.gyp is currently being applied to the wrong conditional block.

Attached a proposed patch based on the existing work from William Hubbs.
Comment 1 Guillaume Ceccarelli 2024-12-19 13:26:44 UTC
Created attachment 914359 [details]
portion of build.log demonstrating the build failure
Comment 2 Guillaume Ceccarelli 2024-12-19 13:27:42 UTC
Created attachment 914360 [details]
dmesg output giving context to the build failure
Comment 3 Guillaume Ceccarelli 2024-12-19 13:28:23 UTC
Created attachment 914361 [details]
emerge --info
Comment 4 Larry the Git Cow gentoo-dev 2024-12-26 03:30:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e565147a654479c47d5254366182c94f9bef681e

commit e565147a654479c47d5254366182c94f9bef681e
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2024-12-26 03:24:35 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2024-12-26 03:25:45 +0000

    net-libs/nodejs: 22.12.0-r1 revbump to update pax-marking patch
    
    Closes: https://bugs.gentoo.org/946669
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 .../nodejs/files/nodejs-22.12.0-paxmarking.patch   | 102 +++++++
 net-libs/nodejs/nodejs-22.12.0-r1.ebuild           | 293 +++++++++++++++++++++
 2 files changed, 395 insertions(+)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-26 03:41:14 UTC
I don't think that requires a revbump (it's build-time-only and nodejs really takes ages to build)