Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946639 - x11-drivers/xf86-video-vesa runtime constraints needlessly strict
Summary: x11-drivers/xf86-video-vesa runtime constraints needlessly strict
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-18 16:53 UTC by stefan11111
Modified: 2024-12-19 10:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description stefan11111 2024-12-18 16:53:19 UTC 
xf86-video-vesa has the following snippet of code in src/vesa.c:

>#ifdef __linux__
>    if (VESAFileExistsPrefix("/dev", "fb") ||
>        VESAFileExistsPrefix("/dev/dri", "card")) {
>        ErrorF("vesa: Refusing to run, Framebuffer or dri device present\n");
>        return FALSE;
>    }
>#endif

This code checks if there are files matching /dev/fb* or /dev/dri/card*, and if there are any, refuses to run.

This requirement is needlessly strict.
I have a framebuffer at /dev/fb0, yet I can also use the vesa driver if I remove this check.

--- a/src/vesa.c        2024-12-18 13:20:50.976466197 +0200
+++ b/src/vesa.c        2024-12-18 13:21:15.869427641 +0200
@@ -478,6 +478,7 @@
 {
     ScrnInfoPtr pScrn;

+#if 0
 #ifdef __linux__
     if (VESAFileExistsPrefix("/dev", "fb") ||
         VESAFileExistsPrefix("/dev/dri", "card")) {
@@ -485,6 +486,7 @@
         return FALSE;
     }
 #endif
+#endif

     pScrn = xf86ConfigPciEntity(NULL, 0, entity_num, NULL,
                                NULL, NULL, NULL, NULL, NULL);

If I apply the above patch, the vesa driver works without issue.