Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946224 - games-engines/scummvm - Add new dependencies
Summary: games-engines/scummvm - Add new dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-10 20:01 UTC by Le Philousophe
Modified: 2024-12-11 10:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
scummvm-2.9.0-r1.ebuild (scummvm-2.9.0-r1.ebuild,3.59 KB, text/plain)
2024-12-10 20:02 UTC, Le Philousophe
Details
metadata.xml patch (metadata.patch,980 bytes, patch)
2024-12-10 20:03 UTC, Le Philousophe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Le Philousophe 2024-12-10 20:01:06 UTC
The new 2.9 version of ScummVM adds a number of optional dependencies.

This package updates them and also adds some dependencies which were available in previous versions:
mikmod/openmpt, musepack and vpx support (needed by some engines), parallel port (needed for some real OPL devices), readline (for console based debugger).
It also fixes the specific configure handling for fluidsynth now that --enable-fluidsynth is properly supported.

An update of the metadata is also needed for the new USE-flags.

Finally, to make pkgcheck happy, some USE masks need to be applied.

libvpx is masked on big-endian platforms.
So, in features/big-endian/package.use.mask, games-engines/scummvm needs to be added to the vpx mask list.

Parallel port is not available for riscv and ppc64 (no libieee1284).
In arch/powerpc/ppc64/use.mask and arch/riscv/use.mask, add the parport use flag.
This is a global use flag but it seems to have no impact on existing packages.
Comment 1 Le Philousophe 2024-12-10 20:02:03 UTC
Created attachment 913744 [details]
scummvm-2.9.0-r1.ebuild
Comment 2 Le Philousophe 2024-12-10 20:03:31 UTC
Created attachment 913745 [details, diff]
metadata.xml patch
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-12-11 06:46:35 UTC
Ah, sorry.  I forgot that they've using a custom configure script, so my grep for configure.{ac,in} missed it.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-12-11 10:08:15 UTC
Thanks for the detailed report.  I've done most of it, but I've skipped libmikmod since it's redundant to libopenmpt.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-12-11 10:56:41 UTC
For the record:

- readline is only used if we enable text console.  Since there should be no harm to enabling it unconditionally, I've done that.

- vpx is only used by USE=unsupported (otherwise as-needed drops it).  However, I'll leave it independent, since I don't want to track whether "supported" games start to use it.
Comment 6 Larry the Git Cow gentoo-dev 2024-12-11 10:57:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef61f8be518e5da65b0479d8f4d7892f25ae411c

commit ef61f8be518e5da65b0479d8f4d7892f25ae411c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-11 10:07:52 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-11 10:57:08 +0000

    games-engines/scummvm: Enable parallel port support
    
    Closes: https://bugs.gentoo.org/946224
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-engines/scummvm/metadata.xml            |   1 +
 games-engines/scummvm/scummvm-2.9.0-r1.ebuild | 155 ++++++++++++++++++++++++++
 games-engines/scummvm/scummvm-9999.ebuild     |   6 +-
 3 files changed, 160 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c1a1b03b47894ff9b0f241f80b6612200e44960

commit 2c1a1b03b47894ff9b0f241f80b6612200e44960
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-11 10:01:01 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-11 10:57:08 +0000

    games-engines/scummvm: Enable openmpt support
    
    Bug: https://bugs.gentoo.org/946224
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-engines/scummvm/metadata.xml         | 1 +
 games-engines/scummvm/scummvm-2.9.0.ebuild | 8 ++++++--
 games-engines/scummvm/scummvm-9999.ebuild  | 8 ++++++--
 3 files changed, 13 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f32a56eeb5b005a5dacc47cf0b837297970b75a

commit 2f32a56eeb5b005a5dacc47cf0b837297970b75a
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-11 09:53:32 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-11 10:57:07 +0000

    games-engines/scummvm: Enable readline support for text console
    
    Bug: https://bugs.gentoo.org/946224
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-engines/scummvm/scummvm-2.9.0.ebuild | 6 ++++--
 games-engines/scummvm/scummvm-9999.ebuild  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4ece371ecd8658fdfd0ed20575cf90a670b03cf

commit e4ece371ecd8658fdfd0ed20575cf90a670b03cf
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-11 09:50:02 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-11 10:57:05 +0000

    games-engines/scummvm: Enable vpx support
    
    Bug: https://bugs.gentoo.org/946224
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-engines/scummvm/metadata.xml            | 1 +
 games-engines/scummvm/scummvm-2.9.0.ebuild    | 4 +++-
 games-engines/scummvm/scummvm-9999.ebuild     | 4 +++-
 profiles/features/big-endian/package.use.mask | 1 +
 4 files changed, 8 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c8fc7b25eaea776d0a1c85e49bc890f11fae13e

commit 2c8fc7b25eaea776d0a1c85e49bc890f11fae13e
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-11 09:37:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-11 10:57:05 +0000

    games-engines/scummvm: Enable musepack support
    
    Bug: https://bugs.gentoo.org/946224
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-engines/scummvm/scummvm-2.9.0.ebuild | 6 ++++--
 games-engines/scummvm/scummvm-9999.ebuild  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)