Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 946192 - net-misc/moonlight-6.1.0 w/ media-video/ffmpeg-4.x: .../plvk_c.c:19:10: error: conflicting types for 'av_stream_get_side_data'; [...]
Summary: net-misc/moonlight-6.1.0 w/ media-video/ffmpeg-4.x: .../plvk_c.c:19:10: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: James Le Cuirot
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-12-10 09:40 UTC by dE
Modified: 2025-01-01 16:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Failed build log for net-misc/moonlight-6.1.0 with ffmpeg-4 (moonlight_failed_build.log,160.48 KB, text/x-log)
2024-12-10 09:40 UTC, dE
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dE 2024-12-10 09:40:06 UTC
Created attachment 913722 [details]
Failed build log for net-misc/moonlight-6.1.0 with ffmpeg-4

net-misc/moonlight requires ffmpeg-6 since AV_PIX_FMT_P410 is not defined in ffmpeg-4.

https://github.com/FFmpeg/FFmpeg/blob/release/4.4/libavutil/pixfmt.h
Does not have it, while https://github.com/FFmpeg/FFmpeg/blob/release/6.0/libavutil/pixfmt.h does have it.

AV_PIX_FMT_P410 is used in streaming/video/ffmpeg-renderers/plvk.cpp
Comment 1 dE 2024-12-10 09:42:40 UTC
ffmpeg-4 is needed by vlc[ffmpeg].

If only there was an option to compile with support of a local ffmpeg copy (within moonlight sources) because it seems like there is such an option with mac and windows.
Comment 2 Andreas Sturmlechner gentoo-dev 2024-12-10 16:09:30 UTC
(In reply to dE from comment #1)
> ffmpeg-4 is needed by vlc[ffmpeg].
That's not really correct, as only media-video/vlc[vaapi] has that restriction, and 3.0.21-r1 not any longer.

So, looks like the ebuild just needs to define an appropriate minimum version.
Comment 3 dE 2024-12-11 08:59:20 UTC
(In reply to Andreas Sturmlechner from comment #2)
> (In reply to dE from comment #1)
> > ffmpeg-4 is needed by vlc[ffmpeg].
> That's not really correct, as only media-video/vlc[vaapi] has that
> restriction, and 3.0.21-r1 not any longer.
> 
> So, looks like the ebuild just needs to define an appropriate minimum
> version.

Thanks for the update. Many were waiting for it since ages.
Comment 4 Larry the Git Cow gentoo-dev 2025-01-01 16:48:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6b4a96d11bba6bdbf428f293cca36a870b1516c

commit e6b4a96d11bba6bdbf428f293cca36a870b1516c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-01-01 12:26:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-01 16:47:45 +0000

    net-misc/moonlight: Drop IUSE qt5, raise minimum ffmpeg version to 6
    
    Make Qt6 non-optional
    Minor ebuild style fixes
    
    Closes: https://bugs.gentoo.org/946192
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-misc/moonlight/moonlight-6.1.0-r1.ebuild | 82 ++++++++++++++++++++++++++++
 net-misc/moonlight/moonlight-9999.ebuild     | 39 ++++---------
 2 files changed, 93 insertions(+), 28 deletions(-)