Build will fail with error on: ../../../../../qtwebengine-everywhere-src-6.8.1/src/3rdparty/chromium/third_party/blink/renderer/platform/wtf/text/string_concatenate.h:178:43: note: remove the ‘< >’ ../../../../../qtwebengine-everywhere-src-6.8.1/src/3rdparty/chromium/third_party/blink/renderer/modules/serial/serial_port_underlying_sink.h:23:49: error: ‘Dispose’ has not been declared 23 | USING_PRE_FINALIZER(SerialPortUnderlyingSink, Dispose); | ^~~~~~~ ../../../../../qtwebengine-everywhere-src-6.8.1/src/3rdparty/chromium/third_party/blink/renderer/modules/serial/serial_port_underlying_sink.h:23:3: error: ISO C++ forbids declaration of ‘USING_PRE_FINALIZER’ with no type [-fpermissive] 23 | USING_PRE_FINALIZER(SerialPortUnderlyingSink, Dispose); | ^~~~~~~~~~~~~~~~~~~
Created attachment 913206 [details] eclass-debug.log
Created attachment 913207 [details] enviroment
Please include build.log and emerge --info too (assume it's coming but just saying in case).
Created attachment 913208 [details] build.log part 1
Created attachment 913209 [details] build.log part 2
Created attachment 913210 [details] emerge --info
Haven't tried but almost certainly only happens with USE=-jumbo-build (I almost never test that given how much longer it takes to build). I'll have a look but it'll probably take a while (maybe not today), I'd suggest to just enable it in the interim. It's default so it shouldn't affect too many users thankfully.
ok, I will run the build with "jumbo-build" enabled
Hm, haven't looked too in-depth yet, but this line actually shouldn't be in chromium-122 that Qt is using, so I'm guessing [1] was used in a security backport and it probably missed another commit that adds prefinalizer.h somewhere (works by accident by combining files w/ jumbo-build). [1] https://github.com/chromium/chromium/commit/8ecbee8becf25733afa6dde28c3fde6a1ee2498e
(6.8.1 specific given 6.8.0 does not have this)
I can confirm jumbo-build works fine
(In reply to Pavol Cvengros from comment #11) > I can confirm jumbo-build works fine Thanks, I'll fix -jumbo once these test builds finish assuming I'm still there by then (otherwise it'll be tomorrow). (In reply to Ionen Wolkens from comment #9) > it probably missed another commit that adds prefinalizer.h somewhere It should probably be included in the file that uses it but upstream chromium isn't broken because of [1] adding: +#include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h" Which itself has the needed: #include "third_party/blink/renderer/platform/heap/prefinalizer.h" So.. this is technically fixed in Qt dev branch already which has chromium-126 or so. [1] https://github.com/chromium/chromium/commit/dc046dfad1eff473e0ec946b9412ee6cd3c07ac4
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70dc2b7dc6859ab2ce177f259ccaccf145d886b5 commit 70dc2b7dc6859ab2ce177f259ccaccf145d886b5 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2024-12-03 11:32:27 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2024-12-03 17:14:39 +0000 dev-qt/qtwebengine: update patchset for >=6.8.1 again 6.8-6 -> 6.8-7 changes: Added: * gcc-ICE-workaround.patch (imported from files/) * missing-prefinalizer.patch (bug #945808) Hopefully no more patches for a while (at least none of these needed revbumps). Closes: https://bugs.gentoo.org/945808 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> dev-qt/qtwebengine/Manifest | 2 +- .../qtwebengine-6.8.1-gcc-ICE-workaround.patch | 36 ---------------------- dev-qt/qtwebengine/qtwebengine-6.8.1.ebuild | 3 +- dev-qt/qtwebengine/qtwebengine-6.8.9999.ebuild | 3 +- dev-qt/qtwebengine/qtwebengine-6.9999.ebuild | 3 +- 5 files changed, 4 insertions(+), 43 deletions(-)
