Bug 945772 – dev-python/pyside6: either split UiTools into its own default-enabled USE, or merge into USE=widgets (was media-gfx/freecad: should dev-python/pyside6:=[designer] depend on local use flag?)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Craig Sowadski 2024-12-02 23:03:14 UTC]

should:
dev-python/pyside6:=[designer,gui,svg,${PYTHON_USEDEP}]

be:
dev-python/pyside6:=[designer?,gui,svg,${PYTHON_USEDEP}]


Seems strange to me to pull in designer deps when the local use flag is not set.

[Comment 1 Ionen Wolkens 2024-12-03 02:14:10 UTC]

Haven't looked myself but I think it's "correct" (see bottom line of commit below). Quotes given I'd say this can be considered a bug for pyside6 instead.

The designer+uitools merging is likely confusion from our Qt5 layout which split qttools into separate packages and UiTools ended up being part of dev-qt/designer:5.

With Qt6, you can get UiTools with qttools:6[widgets] even with USE=-designer (and widgets is default enabled, designer is not because very few users actually need this).

So, could argue that pyside6 should gain a USE=uitools flag or similar and enable it by default (trivial given most people will have qttools[widgets]) so that users (that don't really need it) won't have to enable designer on qttools and pyside6.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcdce40e9a6b
Author: Chris Mayo <[e-mail]>
Date:   Sun Nov 24 15:24:29 2024

    media-gfx/freecad: dev-qt/qttools:6[designer] is optional
    
    gui needs qttools for UiTools, then if designer also Designer
    
    cMake/FreeCAD_Helpers/SetupQt.cmake:
    
    if(BUILD_GUI)
        elseif (FREECAD_QT_MAJOR_VERSION EQUAL 6)
            list (APPEND FREECAD_QT_COMPONENTS GuiTools)
            list (APPEND FREECAD_QT_COMPONENTS SvgWidgets)
        endif()
    
        list (APPEND FREECAD_QT_COMPONENTS OpenGL PrintSupport Svg UiTools Widgets
    
        if(BUILD_DESIGNER_PLUGIN)
            list (APPEND FREECAD_QT_COMPONENTS Designer)
    
    But for PySide6, the Gentoo ebuild states:
     # Note that the "designer" USE flag corresponds to the "Qt6UiTools" module.

[Comment 2 Ionen Wolkens 2024-12-03 02:19:36 UTC]

Guess merging into USE=widgets could be a reasonable option as well, up to maintainer.

[Comment 3 Ionen Wolkens 2024-12-03 10:19:45 UTC]

On another note, just noticed pyside6 does not depend on qttools:6[widgets] at all. It's unlikely but a user *could* disable that and it'll result in UiTools probably getting automagic disabled in pyside6.

[Comment 4 Ionen Wolkens 2024-12-03 10:21:02 UTC]

(In reply to Ionen Wolkens from comment #3)
> On another note, just noticed pyside6 does not depend on qttools:6[widgets]
> at all. It's unlikely but a user *could* disable that and it'll result in
> UiTools probably getting automagic disabled in pyside6.
No wait, scratch that.. it's actually saved by qttools' REQUIRED_USE="designer? ( widgets )", not that it shouldn't have the explicit dependency anyway.

[Comment 5 Nowa Ammerlaan 2024-12-03 10:23:31 UTC]

How is this handled in pyqt6? There seems to be no USE flag specifically for UITools. I'd like to have as much symmetry as possible to avoid confusion and to keep QtPy.ebuild simple.

[Comment 6 Ionen Wolkens 2024-12-03 10:31:12 UTC]

(In reply to Nowa Ammerlaan from comment #5)
> How is this handled in pyqt6? There seems to be no USE flag specifically for
> UITools. I'd like to have as much symmetry as possible to avoid confusion
> and to keep QtPy.ebuild simple.
It doesn't exist, PyQt6 does not have support for Qt6UiTools.

[Comment 7 Ionen Wolkens 2024-12-03 10:37:46 UTC]

(In reply to Ionen Wolkens from comment #6)
> It doesn't exist, PyQt6 does not have support for Qt6UiTools.
..but if it did, decent odds I would've done a USE=uitools when I wrote the PyQt6 ebuild. Similar deal as USE=help which is also from qttools (Qt6Help.so -> help, Qt6UiTools.so -> uitools)

[Comment 8 Larry the Git Cow 2024-12-20 16:09:47 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=25deac86bc680104813c1300f1e6ee84f007381d

commit 25deac86bc680104813c1300f1e6ee84f007381d
Author:     Nowa Ammerlaan <[e-mail]>
AuthorDate: 2024-12-20 15:58:32 +0000
Commit:     Nowa Ammerlaan <[e-mail]>
CommitDate: 2024-12-20 16:09:07 +0000

    dev-python/pyside6: add 6.8.1
    
    Closes: https://bugs.gentoo.org/945772
    Closes: https://bugs.gentoo.org/946285
    Signed-off-by: Nowa Ammerlaan <[e-mail]>

 dev-python/pyside6/Manifest             |   1 +
 dev-python/pyside6/metadata.xml         |   4 +
 dev-python/pyside6/pyside6-6.8.1.ebuild | 253 ++++++++++++++++++++++++++++++++
 3 files changed, 258 insertions(+)