https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: mail-client/alpine-2.26-r5 fails to compile. Discovered on: amd64 (internal ref: ci) Info about the issue: https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Created attachment 911924 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: 1 out of 1 hunk FAILED -- saving rejects to file pith/pine.hlp.rej * environment, line 967: Called __helpers_die 'patch -p1 failed with /var/tmp/portage/mail-client/alpine-2.26-r5/work/alpine-2.26-patches/0023-Fix-for-a-better-bound-check-in-imap-src-c-client-nn.patch' Hunk #1 FAILED at 147. * patch -p1 failed with /var/tmp/portage/mail-client/alpine-2.26-r5/work/alpine-2.26-patches/0023-Fix-for-a-better-bound-check-in-imap-src-c-client-nn.patch
Why are the patches applied in the wrong order? Of course this won't work.
(In reply to Holger Hoffstätte from comment #3) > Why are the patches applied in the wrong order? Of course this won't work. Because find I only ever used tmpfs which observes insertion order :( Just adding a sort after the find should do it.
Why don't you just eapply "${WORKDIR}"/${P}-patches/0*.patch without the find and the loop? eapply can accept multiple arguments.
I reproduced the problem by using PORTAGE_TMPFS on a machine with ext4. The PR fixes it by explicitly sorting the list.
(In reply to Ulrich Müller from comment #5) > Why don't you just > eapply "${WORKDIR}"/${P}-patches/0*.patch > without the find and the loop? eapply can accept multiple arguments. Didn't know that :-(
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=946770868f05d7340adad87bde656ec5b70644b3 commit 946770868f05d7340adad87bde656ec5b70644b3 Author: Holger Hoffstätte <holger@applied-asynchrony.com> AuthorDate: 2024-11-26 11:02:49 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2024-11-26 11:31:57 +0000 mail-client/alpine: list of patches must be sorted Use eapply instead of find, which will implicitly sort the list of patches. This also simplifies the entire procedure. Closes: https://bugs.gentoo.org/944973 Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com> Signed-off-by: Ulrich Müller <ulm@gentoo.org> mail-client/alpine/alpine-2.26-r5.ebuild | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
