Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 944837 - net-im/pidgin: reevaluate strip-flags & replace-flags use
Summary: net-im/pidgin: reevaluate strip-flags & replace-flags use
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andreas Schürch
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-11-25 02:35 UTC by Sam James
Modified: 2025-04-10 09:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-25 02:35:14 UTC
src_configure has:
```
        # Stabilize things, for your own good
        strip-flags
        replace-flags -O? -O2
```

I doubt this is really needed still. If it is, it should be accompanied with a bug reference.
Comment 1 CFuga 2025-03-25 21:43:34 UTC
I'm almost sure that's not really needed.

+20 years ago there's was a bug with net-im/gaim, probably caused by gcc-2.95 and -Os optimization.

https://bugs.gentoo.org/29394

The following developers and maintainers just copied those lines when bumping versions, and nobody tried to remove them with new Gaim/Pidgin/GCC versions.

Also x11-plugins/pidgin-encryption has the same code; I guess the Gentoo maintainer/developer was extra cautious.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-26 12:07:58 UTC
(In reply to CFuga from comment #1)
> I'm almost sure that's not really needed.
> 
> +20 years ago there's was a bug with net-im/gaim, probably caused by
> gcc-2.95 and -Os optimization.
> 
> https://bugs.gentoo.org/29394
> 
> The following developers and maintainers just copied those lines when
> bumping versions, and nobody tried to remove them with new Gaim/Pidgin/GCC
> versions.
> 
> Also x11-plugins/pidgin-encryption has the same code; I guess the Gentoo
> maintainer/developer was extra cautious.

Given you did the research, mind doing a PR to drop it (in a new revision) with that context in the commit message, and a Closes: for this bug (and a Bug: for the old one)? Thank you!
Comment 3 Larry the Git Cow gentoo-dev 2025-04-10 09:33:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d9891cab30df71423ccb306dde5eacacf146b56

commit 8d9891cab30df71423ccb306dde5eacacf146b56
Author:     Cristian Othón Martínez Vera <cfuga@cfuga.mx>
AuthorDate: 2025-03-26 16:42:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-10 09:32:00 +0000

    net-im/pidgin: drop strip/replace compiler flags by default, enable py3.13
    
    +20 years ago there was a bug with ```net-im/gaim```, probably caused by
    gcc-2.95 and ```-Os``` optimization.
    
    The following developers and maintainers just copied those lines when bumping
    versions, and nobody tried to remove them with new Gaim/Pidgin/GCC versions.
    
    Bug: https://bugs.gentoo.org/29394
    Closes: https://bugs.gentoo.org/944837
    Signed-off-by: Cristian Othón Martínez Vera <cfuga@cfuga.mx>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-im/pidgin/{pidgin-2.14.14.ebuild => pidgin-2.14.14-r1.ebuild} | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)