Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 944812 - kde-apps/dolphin: Missing dependency on kde-plasma/kde-cli-tools
Summary: kde-apps/dolphin: Missing dependency on kde-plasma/kde-cli-tools
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay, PullRequest
Depends on: 945880
Blocks: plasma-6.2.3-stable, plasma-6.2.4-stable
  Show dependency tree
 
Reported: 2024-11-24 12:47 UTC by Tobias Leupold
Modified: 2024-12-04 22:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2024-11-24 12:47:30 UTC
Hi all,

I just wanted to edit the default program to start a certain MIME type file with  using Dolphin and got

    The executable program "keditfiletype" cannot be found in PATH

(or whatever it may be in C locale).

/usr/bin/keditfiletype is part of kde-plasma/kde-cli-tools, which wasn't installed on my system (maybe removed by some depclean?).

I think Dolphin should pull this as it apparently needs it for basic functionality? Maybe, during the KF6 transition, something was lost (as there's also kde-plasma/kde-cli-tools-common)?

Thanks for having a look at this!
Comment 1 Tobias Leupold 2024-11-24 13:05:13 UTC
PS: After installing kde-plasma/kde-cli-tools manually, I also noticed that "moung and open" of external media works again. The last time, I could only mount e.g. an USB-Stick, but Dolphin would not be launched to view it's content automatically.

So maybe, kde-plasma/kde-cli-tools even should be already pulled by the Plasma desktop itself.
Comment 2 Andreas Sturmlechner gentoo-dev 2024-11-24 22:12:07 UTC
No, kde-apps/dolphin has never depended on kde-cli-tools, to my knowledge. However, in Plasma 5 it was much more prevalent since it contained the kcmshell binary, so the missing dep was not found out.

And actually, in those times it came with a pretty hefty hard-dependency on plasma-workspace too, but KWin - among many other deps - was also depending on kde-cli-tools, so I had to put in the effort to make a custom standalone cmake buildsys for kde-plasma/libkworkspace:5. Fun, not.

I was actually already looking at dolphin once, but could not put my finger on where exactly the dependency was coming in. Searching on lxr.kde.org for keditfiletype, dolphin actually does *not* show up, but kwidgetsaddons does. Yet - its error message does not match yours!

Following up on source level splits, we actually have a nifty eclass mechanism now that manages to deal with simple ECM-based repositories in order to split out common files or easily build a certain (independent enough) subdir. I already made use of that with kde-plasma/kdesu-gui and kde-plasma/kde-cli-tools-common, and we can do the same with keditfiletype too. However, before we should firmly establish in what revdeps it is needed.
Comment 3 Andreas Sturmlechner gentoo-dev 2024-11-24 22:15:54 UTC
(In reply to Tobias Leupold from comment #1)
> So maybe, kde-plasma/kde-cli-tools even should be already pulled by the
> Plasma desktop itself.
kde-plasma/plasma-meta hard-depends on kde-plasma/kde-cli-tools. If you don't use that meta ebuild, you are on your own to define what "minimal" means.
Comment 4 Tobias Leupold 2024-11-25 11:45:03 UTC
Thanks for the follow-up! kde-plasma/plasma-meta actually wasn't installed ... must have gone lost whilst I upgraded to KF6 before it was stable/easy/ready back then. Thanks a lot for that hint.

That error message is q bit strange indeed. Examining the Dolphin sources, they don't even contain the string "keditfiletype", even less the error message I got ...

Must come from somewhere else. Maybe from the "File Associations" KCM module?! I couldn't locate it yet ...
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-25 14:25:35 UTC
I think it's coming from kde-frameworks/kwidgetsaddons.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-25 14:26:20 UTC
(In reply to Sam James from comment #5)
> I think it's coming from kde-frameworks/kwidgetsaddons.

Introduced in https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/7fc2843f57aa0f170b1838f4eecb806cbd516c10.
Comment 7 Andreas Sturmlechner gentoo-dev 2024-11-25 18:52:41 UTC
Yes. When I reproduce the problem, the error message matches with kwidgetsaddons. And of course the same happens also using krusader or file dialogs, whatever provides the file properties (KStandardGuiItem, I guess).
Comment 8 Andreas Sturmlechner gentoo-dev 2024-11-25 22:41:07 UTC
Here's one avenue we can take.
Comment 9 Larry the Git Cow gentoo-dev 2024-11-26 18:18:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=a8a20aa51adf97ccff35df1c521e86e189e1dd18

commit a8a20aa51adf97ccff35df1c521e86e189e1dd18
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-11-25 22:18:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-11-26 18:17:55 +0000

    kde-frameworks/kio: PDEPEND on kde-plasma/keditfiletype
    
    KWidgetsAddons has runtime dependency on keditfiletype binary, but as Tier1
    Framework only depends on Qt modules. keditfiletype otoh has rather heavy
    dependencies (including KIO itself), so it cannot be a dependency of
    KWidgetsAddons.
    
    As a compromise, put it into PDEPEND here, since KFileWidget exposes this
    KWidgetsAddons component, and revdeps like dolphin and krusader (typical
    consumers of KIO) too.
    
    Bug: https://bugs.gentoo.org/944812
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/kio/kio-9999.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/proj/kde.git/commit/?id=c3bafa1312d3b43fd29ec9c9545b0df01ded44a8

commit c3bafa1312d3b43fd29ec9c9545b0df01ded44a8
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-11-25 21:54:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-11-26 18:17:55 +0000

    kde-plasma/keditfiletype: new package, add 6.2.49.9999, 9999
    
    Bug: https://bugs.gentoo.org/944812
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/keditfiletype-6.2.4-build-restrict.patch | 74 ++++++++++++++++++++++
 .../files/keditfiletype-6.2.4-unused-dep.patch     | 26 ++++++++
 .../files/keditfiletype-6.2.4-unused-include.patch | 25 ++++++++
 .../keditfiletype/keditfiletype-6.2.49.9999.ebuild | 52 +++++++++++++++
 kde-plasma/keditfiletype/keditfiletype-9999.ebuild | 49 ++++++++++++++
 kde-plasma/keditfiletype/metadata.xml              | 12 ++++
 6 files changed, 238 insertions(+)
Comment 10 Tobias Leupold 2024-11-26 18:36:32 UTC
Thanks for working on this :-)
Comment 11 Larry the Git Cow gentoo-dev 2024-11-27 18:44:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f21c6b7747da062ddabb68a5b79ded0c81b52b02

commit f21c6b7747da062ddabb68a5b79ded0c81b52b02
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-11-25 22:18:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-11-27 18:44:04 +0000

    kde-frameworks/kio: PDEPEND on kde-plasma/keditfiletype
    
    KWidgetsAddons has runtime dependency on keditfiletype binary, but as Tier1
    Framework only depends on Qt modules. keditfiletype otoh has rather heavy
    dependencies (including KIO itself), so it cannot be a dependency of
    KWidgetsAddons.
    
    As a compromise, put it into PDEPEND here, since KFileWidget exposes this
    KWidgetsAddons component, and revdeps like dolphin and krusader (typical
    consumers of KIO) too.
    
    Closes: https://bugs.gentoo.org/944812
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/kio/kio-6.8.0-r1.ebuild | 96 ++++++++++++++++++++++++++++++++++
 1 file changed, 96 insertions(+)
Comment 12 Larry the Git Cow gentoo-dev 2024-12-04 22:07:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44ad1a3522f8aa64a434a3b115f2d0f1ad1e6829

commit 44ad1a3522f8aa64a434a3b115f2d0f1ad1e6829
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-11-25 22:18:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-12-04 22:07:51 +0000

    kde-frameworks/kio: PDEPEND on kde-plasma/keditfiletype
    
    KWidgetsAddons has runtime dependency on keditfiletype binary, but as Tier1
    Framework only depends on Qt modules. keditfiletype otoh has rather heavy
    dependencies (including KIO itself), so it cannot be a dependency of
    KWidgetsAddons.
    
    As a compromise, put it into PDEPEND here, since KFileWidget exposes this
    KWidgetsAddons component, and revdeps like dolphin and krusader (typical
    consumers of KIO) too.
    
    Bug: https://bugs.gentoo.org/944812
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/kio/kio-6.7.0-r1.ebuild | 98 ++++++++++++++++++++++++++++++++++
 1 file changed, 98 insertions(+)