Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 944564 - =media-gfx/gphoto2-2.5.28-r1 gcc-14 build error: passing argument 4 of ‘newCDKDialog’ from incompatible pointer type
Summary: =media-gfx/gphoto2-2.5.28-r1 gcc-14 build error: passing argument 4 of ‘newCD...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on: 944566
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-11-23 09:52 UTC by Zdenek Sojka
Modified: 2024-12-20 05:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,19.02 KB, text/x-log)
2024-11-23 09:52 UTC, Zdenek Sojka
Details
emerge --info (emerge--info.log,9.41 KB, text/x-log)
2024-11-23 09:54 UTC, Zdenek Sojka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zdenek Sojka 2024-11-23 09:52:55 UTC
Created attachment 911631 [details]
build.log

# CCACHE_DISABLE=1 MAKEOPTS=-j1 emerge -v1 media-gfx/gphoto2

These are the packages that would be merged, in order:

Calculating dependencies... done!
Dependency resolution took 4.69 s (backtrack: 0/20).

[ebuild   R    ] media-gfx/gphoto2-2.5.28-r1::gentoo  USE="ncurses nls readline -aalib" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

...

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -DLOCALEDIR=\"/usr/share/locale\" -D_GPHOTO2_INTERNAL_CODE  -I.. -I../gphoto2 -I/usr/include/gphoto2 -I/usr/include/libexif -DLOCALEDIR=\"/usr/share/locale\" -D_GPHOTO2_INTERNAL_CODE  -I/usr/include/cdk  -I/usr/include/libexif   -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -O3 -pipe -flto=auto -march=native -fomit-frame-pointer -fipa-cp-clone -finline-functions -fno-stack-protector -fno-stack-clash-protection -Wall -Wmissing-declarations -Wmissing-prototypes -c -o gphoto2-gphoto2-cmd-config.o `test -f 'gphoto2-cmd-config.c' || echo './'`gphoto2-cmd-config.c
gphoto2-cmd-config.c: In function ‘set_config’:
gphoto2-cmd-config.c:74:42: error: passing argument 4 of ‘newCDKDialog’ from incompatible pointer type [-Wincompatible-pointer-types]
   74 |                                          msg, 4, buttons, 2,
      |                                          ^~~
      |                                          |
      |                                          const char **
...
Comment 1 Zdenek Sojka 2024-11-23 09:54:05 UTC
Created attachment 911632 [details]
emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-23 09:54:51 UTC
What version of cdk? See bug 919279.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-23 09:55:22 UTC
(In reply to Sam James from comment #2)
> What version of cdk? See bug 919279.

Ah, nevermind, but also.. I didn't ever add a >= dep on that?
Comment 4 Zdenek Sojka 2024-11-23 10:05:47 UTC
(In reply to Sam James from comment #2)
> What version of cdk? See bug 919279.

Thank you for the reply!
I am on (mostly) stable system, thus =dev-libs/cdk-5.0.20230201.
I verified gphoto2 builds correctly with ~amd64 ==dev-libs/cdk-5.0.20230201-r1

I am sorry, when I was searching for "media-gfx/gphoto2", only bug 893204 and bug 831226 were listed in the search results, and there is no ~amd64 gphoto2 I could test.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-23 10:09:33 UTC
No problem (and hi, by the way). Thanks for the reports.

I'm sorry I've missed some of these -- a lot of preparation went into GCC 14 porting, but there's this nasty trade-off where the longer a transition goes on, the easier it is to forget about some silly bits like this where you have some missing stabilisation of a fix :(
Comment 6 Zdenek Sojka 2024-11-23 13:03:59 UTC
Thank you for your efforts, having new gcc stabilised just half a year after its release is fast; things have really improved since gcc-4.0/1/2 times. It's also the code base, gcc is emiting more warnings and developers in general are writing standard-conforming code. Only a few packages is using strip-flags or filter-flags, and only a minority is using filter-lto, nevertheless I am building with -O3 -flto with only rare issues.
Comment 7 Larry the Git Cow gentoo-dev 2024-12-20 05:50:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da9c5efc94918162057159424d556ed556c02675

commit da9c5efc94918162057159424d556ed556c02675
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-20 05:49:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-20 05:49:35 +0000

    media-gfx/gphoto2: depend on fixed cdk
    
    We need to depend on a version of cdk w/ fixed const, see commit
    3c6244c59141bcdd5144430a42b87ab90cea2f19.
    
    Closes: https://bugs.gentoo.org/944564
    Signed-off-by: Sam James <sam@gentoo.org>

 .../gphoto2/{gphoto2-2.5.28-r1.ebuild => gphoto2-2.5.28-r2.ebuild}      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)