https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-gfx/oxipng-9.1.2-r1 fails to compile. Discovered on: arm64 (internal ref: tinderbox_arm64) System: GCC-15-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-15) Info about the issue: https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Created attachment 910982 [details] build.log build log and emerge --info
error: inlining failed in call to 'always_inline' in some builds · Issue #369 · ebiggers/libdeflate · GitHub https://github.com/ebiggers/libdeflate/issues/369 lib/arm: don't use explicit armv8.2-a on gcc 13.2 and later by ebiggers · Pull Request #370 · ebiggers/libdeflate · GitHub https://github.com/ebiggers/libdeflate/pull/370 Looks like this, which has been fixed since libdeflate v1.21.
Can we have it always use a system copy? Or does the crate not support that?
https://github.com/adamkewley/libdeflater/blob/9bd20a39c33cdeed66ea515b983ae694de370be0/libdeflate-sys/build.rs#L8-L17 libdeflate has `dynamic` flag to use system library if available, but it falls back to the bundled version if the corresponding version of the system library is not available. It provides no means to force using system library. (And additionally, `oxipng` does not have feature flag to enable such internal flags.) oxipng and libdeflate_sys can be patched from ebuild, but such patches may need to be updated for every new releases.
Submitted <https://github.com/gentoo/gentoo/pull/39539>. This new revision of oxipng always use system app-arch/libdeflate (instead of the bundled one), so this should fix the bug. Could anyone test this (media-gfx/oxipng-9.1.2-r2) on arm64?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33b61c0ada2a5ec8dd041c73bb5744f9777e4e7d commit 33b61c0ada2a5ec8dd041c73bb5744f9777e4e7d Author: YOSHIOKA Takuma <lo48576@hard-wi.red> AuthorDate: 2024-12-01 13:17:49 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-12-01 14:55:49 +0000 media-gfx/oxipng: use app-arch/libdeflate instead of bundled one Closes: https://bugs.gentoo.org/944285 Signed-off-by: YOSHIOKA Takuma <lo48576@hard-wi.red> Signed-off-by: Sam James <sam@gentoo.org> media-gfx/oxipng/Manifest | 1 + .../files/oxipng-9.1.2-use-system-libdeflate.patch | 38 ++++++ media-gfx/oxipng/oxipng-9.1.2-r2.ebuild | 145 +++++++++++++++++++++ 3 files changed, 184 insertions(+)
