c23 is more strict than previous standards gdm-settings-utils.h:47:77: error: expected ‘;’, ‘,’ or ‘)’ before ‘bool’ Reproducible: Always Steps to Reproduce: [ebuild R ] gnome-base/gdm-46.2-r1::gentoo USE="branding elogind wayland -accessibility -audit -bluetooth-sound -fprint -plymouth (-selinux) -systemd -tcpd -test" 0 KiB Actual Results: FAILED: common/libgdmcommon.a.p/gdm-settings-utils.c.o x86_64-pc-linux-gnu-gcc -Icommon/libgdmcommon.a.p -Icommon -I../gdm-46.2/common -I. -I../gdm-46.2 -I/usr/include/elogind -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -flto=56 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -D_GNU_SOURCE -march=native -O3 -mprefer-vector-width=512 -fno-vect-cost-model -pipe -fPIC -pthread -MD -MQ common/libgdmcommon.a.p/gdm-settings-utils.c.o -MF common/libgdmcommon.a.p/gdm-settings-utils.c.o.d -o common/libgdmcommon.a.p/gdm-settings-utils.c.o -c ../gdm-46.2/common/gdm-settings-utils.c In file included from ../gdm-46.2/common/gdm-settings-utils.c:38: ../gdm-46.2/common/gdm-settings-utils.h:47:77: error: expected ‘;’, ‘,’ or ‘)’ before ‘bool’ 47 | gboolean *bool); | ^~~~ ../gdm-46.2/common/gdm-settings-utils.c:290:50: error: expected ‘;’, ‘,’ or ‘)’ before ‘bool’ 290 | gboolean *bool) | ^~~~ . . . FAILED: common/libgdmcommon.a.p/gdm-settings-direct.c.o x86_64-pc-linux-gnu-gcc -Icommon/libgdmcommon.a.p -Icommon -I../gdm-46.2/common -I. -I../gdm-46.2 -I/usr/include/elogind -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -flto=56 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -D_GNU_SOURCE -march=native -O3 -mprefer-vector-width=512 -fno-vect-cost-model -pipe -fPIC -pthread -MD -MQ common/libgdmcommon.a.p/gdm-settings-direct.c.o -MF common/libgdmcommon.a.p/gdm-settings-direct.c.o.d -o common/libgdmcommon.a.p/gdm-settings-direct.c.o -c ../gdm-46.2/common/gdm-settings-direct.c In file included from ../gdm-46.2/common/gdm-settings-direct.c:38: ../gdm-46.2/common/gdm-settings-utils.h:47:77: error: expected ‘;’, ‘,’ or ‘)’ before ‘bool’ 47 | gboolean *bool); | ^~~~ ../gdm-46.2/common/gdm-settings-direct.c: In function ‘gdm_settings_direct_get_boolean’: ../gdm-46.2/common/gdm-settings-direct.c:159:15: error: implicit declaration of function ‘gdm_settings_parse_value_as_boolean’; did you mean ‘gdm_settings_parse_value_as_double’? [-Wimplicit-function-declaration] 159 | ret = gdm_settings_parse_value_as_boolean (str, value); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | gdm_settings_parse_value_as_double compiles successfully with CFLAGS="${CFLAGS} -std=gnu17"
Created attachment 910921 [details] emerge --info
Created attachment 910922 [details] build fail log
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a405b95e9fce63cf1aa1dd7ec8ebfcb89fa7b666 commit a405b95e9fce63cf1aa1dd7ec8ebfcb89fa7b666 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-11-24 22:21:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-11-24 22:21:16 +0000 gnome-base/gdm: build w/ -std=gnu17 Not going to worry about this more until we have latest version in tree. Closes: https://bugs.gentoo.org/944223 Signed-off-by: Sam James <sam@gentoo.org> gnome-base/gdm/gdm-45.0.1-r2.ebuild | 5 ++++- gnome-base/gdm/gdm-46.2-r1.ebuild | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd30e40c4c2760afd47d83680c0c5847f0de090e commit fd30e40c4c2760afd47d83680c0c5847f0de090e Author: Sam James <sam@gentoo.org> AuthorDate: 2025-01-28 16:58:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-01-28 17:04:01 +0000 gnome-base/gdm: restore lost -std=gnu17 Bug: https://bugs.gentoo.org/944223 Signed-off-by: Sam James <sam@gentoo.org> gnome-base/gdm/gdm-47.0.ebuild | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4c5deba4d44b226cb48342e673f79f782cfd50e commit d4c5deba4d44b226cb48342e673f79f782cfd50e Author: Sam James <sam@gentoo.org> AuthorDate: 2025-01-28 17:07:04 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-01-28 17:07:04 +0000 gnome-base/gdm: backport C23 fix Bug: https://bugs.gentoo.org/944223 Signed-off-by: Sam James <sam@gentoo.org> gnome-base/gdm/files/47.0-c23.patch | 55 +++++++++++++++++++++++++++++++++++++ gnome-base/gdm/gdm-47.0.ebuild | 7 ++--- 2 files changed, 58 insertions(+), 4 deletions(-)
