944070 – =net-dialup/xl2tpd-1.3.18-r2 fails to build c23/gcc-15.0.0_pre20241117-r2: xl2tpd.c:91:35: error: initialization of ‘int (*)(FILE *, char *)’ from incompatible pointer type ‘int (*)(void)’

Bug 944070 - =net-dialup/xl2tpd-1.3.18-r2 fails to build c23/gcc-15.0.0_pre20241117-r2: xl2tpd.c:91:35: error: initialization of ‘int (*)(FILE *, char *)’ from incompatible pointer type ‘int (*)(void)’

Summary: =net-dialup/xl2tpd-1.3.18-r2 fails to build c23/gcc-15.0.0_pre20241117-r2: xl...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Jaco Kroon

URL:
Whiteboard:
Keywords:	PullRequest

Depends on:
Blocks:	c23-porting
	Show dependency tree

Reported:	2024-11-20 03:15 UTC by tdr
Modified:	2024-11-24 23:18 UTC (History)
CC List:	3 users (show)

See Also:	https://github.com/xelerance/xl2tpd/pull/269 https://github.com/gentoo/gentoo/pull/39392
Package list:
Runtime testing required:	---

Attachments
build fail log (xl2tpd-1.3.18-r2.build.log,6.72 KB, text/plain) 2024-11-20 03:15 UTC, tdr	Details
emerge --info (xl2tpd-1.3.18-r2.build.log,6.72 KB, text/plain) 2024-11-20 03:16 UTC, tdr	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description tdr 2024-11-20 03:15:47 UTC

Created attachment 910430 [details]
build fail log

c23 is more strict 
found an incompatible pointer type


xl2tpd.c:91:35: error: initialization of ‘int (*)(FILE *, char *)’ from incompatible pointer type ‘int (*)(void)’ [-Wincompatible-pointer-types]
   91 |     {CONTROL_PIPE_REQ_LAC_STATUS, &control_handle_lac_status},
      |                                   ^
xl2tpd.c:91:35: note: (near initialization for ‘control_handlers[10].handler’)

Comment 1 tdr 2024-11-20 03:16:38 UTC

Created attachment 910431 [details]
emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2024-11-24 23:18:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=478d1858d3deea472be8f143e999ed7b9955633a

commit 478d1858d3deea472be8f143e999ed7b9955633a
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2024-11-20 22:23:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-24 23:18:34 +0000

    net-dialup/xl2tpd: -r3 for c23 patch.
    
    Upstream: https://github.com/xelerance/xl2tpd/pull/269
    
    Closes: https://bugs.gentoo.org/944070
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xl2tpd-1.3.18-r3-Fix-compiling-with-C23.patch  | 37 ++++++++++++
 net-dialup/xl2tpd/xl2tpd-1.3.18-r3.ebuild          | 70 ++++++++++++++++++++++
 2 files changed, 107 insertions(+)