c23 is more strict than previous standards Reproducible: Always Actual Results: rc/shared/shell.c: In function 'rl_cleanup': src/shared/shell.c:1424:9: error: too many arguments to function 'rl_message' 1424 | rl_message(""); | ^~~~~~~~~~ In file included from src/shared/shell.c:29: /usr/include/readline/readline.h:410:12: note: declared here 410 | extern int rl_message (); | ^~~~~~~~~~ /bin/sh ./libtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I./lib -fPIC -ffunction-sections -fdata-sections -march=native -O3 -mprefer-vector-width=512 -fno-vect-cost-model -pipe -c -o src/shared/libshared_ell_la-mcp.lo `test -f 'src/shared/mcp.c' || echo './'`src/shared/mcp.c make[1]: *** [Makefile:8703: src/shared/libshared_mainloop_la-shell.lo] Error 1 works with CFLAGS="${CFLAGS} -std=gnu17" env also builds with gcc:15.0.0_pre20241110
Created attachment 910409 [details] emerge --info
Created attachment 910410 [details] build failure log
*** Bug 944068 has been marked as a duplicate of this bug. ***
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08cc05caea45f6b7c53d95cc5d680055754ef7bb commit 08cc05caea45f6b7c53d95cc5d680055754ef7bb Author: Sam James <sam@gentoo.org> AuthorDate: 2024-11-24 22:29:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-11-24 22:29:16 +0000 net-wireless/bluez: partly fix C23 compat Noticed when looking at bug #944059. This issue was already fixed by the GCC change referenced in bug #943809 but I already did the work to backport these, so let's pull them in. The issue in bug #944059 is an issue in sys-libs/readline which needs to be addressed separately. Bug: https://bugs.gentoo.org/943809 Bug: https://bugs.gentoo.org/944059 Signed-off-by: Sam James <sam@gentoo.org> net-wireless/bluez/bluez-5.79.ebuild | 3 + net-wireless/bluez/files/bluez-5.79-c23.patch | 123 ++++++++++++++++++++++++++ 2 files changed, 126 insertions(+)
The issue is in sys-libs/readline's headers...
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b9a8501590c4b1fa99ff64229a50618ec060db1 commit 6b9a8501590c4b1fa99ff64229a50618ec060db1 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-11-24 22:50:22 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-11-24 22:50:22 +0000 sys-libs/readline: fix compat in headers with C23 HAVE_STDARG_H isn't defined for readline consumers externally so we always end up using the ancient non-prototypes. Fix that as all compilers we care about since forever in Gentoo will support this path. This in particular shows up with rl_message in consumers. Closes: https://bugs.gentoo.org/943820 Closes: https://bugs.gentoo.org/944059 Closes: https://bugs.gentoo.org/944300 Closes: https://bugs.gentoo.org/944344 Signed-off-by: Sam James <sam@gentoo.org> sys-libs/readline/files/readline-8.2-c23.patch | 20 ++ sys-libs/readline/readline-8.2_p13-r1.ebuild | 269 +++++++++++++++++++++++++ 2 files changed, 289 insertions(+)
