Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943914 - x11-plugins/wmmaiload-2.3.0-r2 fails to compile: main.c:749:9: error: too many arguments to function check_cfg_values
Summary: x11-plugins/wmmaiload-2.3.0-r2 fails to compile: main.c:749:9: error: too man...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: c23-porting
  Show dependency tree
 
Reported: 2024-11-19 08:29 UTC by Agostino Sarubbo
Modified: 2025-02-16 20:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,92.48 KB, text/plain)
2024-11-19 08:29 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-11-19 08:29:20 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-plugins/wmmaiload-2.3.0-r2 fails to compile.
Discovered on: amd64 (internal ref: gcc15_tinderbox)
System: GCC-15-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-15)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-11-19 08:29:21 UTC
Created attachment 909722 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-11-19 08:29:22 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


 * 	dobin: wmmaiload/wmmaiload does not exist
 * QA Notice: file does not exist:
!!! dobin: wmmaiload/wmmaiload does not exist
main.c:749:9: error: too many arguments to function ‘check_cfg_values’
Comment 3 NHO 2025-02-14 21:56:47 UTC
Tried to replicate this to fix it.
WHAT KIND OF MESSED UP PACKAGE HAS ERRORED COMPILE STEPS AND MARKS COMPILE AS SUCCESSFUL???
Comment 4 Larry the Git Cow gentoo-dev 2025-02-16 20:09:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f1d6f96e35804b93d84429cb9399fd095a2efc6

commit 7f1d6f96e35804b93d84429cb9399fd095a2efc6
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-02-15 07:07:15 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2025-02-16 20:09:05 +0000

    x11-plugins/wmmaiload: update EAPI 7 -> 8, port to C23
    
    Also add dependency on openssl in build system that was missing from
    ebuild.
    
    Closes: https://bugs.gentoo.org/943914
    Closes: https://bugs.gentoo.org/921310
    Closes: https://bugs.gentoo.org/875470
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../wmmaiload/files/wmmaiload-2.3.0-c23.patch      | 34 +++++++++++++++
 x11-plugins/wmmaiload/wmmaiload-2.3.0-r3.ebuild    | 48 ++++++++++++++++++++++
 2 files changed, 82 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0bbfb8c456266ce3e192d329bbf1f47f4c51f6cc

commit 0bbfb8c456266ce3e192d329bbf1f47f4c51f6cc
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-02-15 07:12:42 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2025-02-16 20:09:05 +0000

    x11-plugins/wmmaiload: Switch build system to meson
    
    Original build system was made by someone who didn't know how to use
    make correctly and was too smart about it. Eg. it uses call to compiler:
    `$(CPP) $(ALL_CPPFLAGS) -MM $$i >> .dependencies` to generate actual build
    commands and `$(shell ls *.c)` to find source files in the directory.
    There is no propagation of errors upwards, so if one of two executables
    fails to compile, it would only be seen at install stage.
    Meson.build replicates end product of configure by passing build
    parameters defined in Config.make. Builds in Gentoo enabled all if them,
    unconditionally.
    Meson.build also gets rid of per-executable config.h and replaces it with
    more build paratemers, as config.h only contains build metadata, like
    OS type, author name, package name and build date. Original build system
    regenerated this mostly-static metadata file on compile, I pass static
    parameters explicitly, with date being an empty string.
    This is supported in program.
    I do not like the end result, but original system is not fit for purpose.
    
    Bug: https://bugs.gentoo.org/943914
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40578
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 x11-plugins/wmmaiload/files/meson.build         | 77 +++++++++++++++++++++++++
 x11-plugins/wmmaiload/wmmaiload-2.3.0-r3.ebuild | 23 +++-----
 2 files changed, 85 insertions(+), 15 deletions(-)