Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943761 - flag-o-matic: wrong flag to negate -fstack-protector-all
Summary: flag-o-matic: wrong flag to negate -fstack-protector-all
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-18 13:05 UTC by Agostino Sarubbo
Modified: 2025-01-28 07:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-11-18 13:05:52 UTC
I didn't use it, but looking at the code of _filter-hardened I can see:


-fstack-protector-all)
if ! gcc-specs-ssp-to-all && ! tc-enables-ssp-all ; then
continue
fi
is-flagq -fno-stack-protector-all || append-flags $(test-flags -fno-stack-protector-all)

but -fno-stack-protector-all is not a valid flag. To Disable stack-protector you need -fno-stack-protector
Comment 1 Larry the Git Cow gentoo-dev 2025-01-28 07:22:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=914fa2ab19a1a8313a05b657e09bc29ec61230a3

commit 914fa2ab19a1a8313a05b657e09bc29ec61230a3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-01-28 07:19:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-28 07:19:22 +0000

    flag-o-matic.eclass: fix negation of -fstack-protector-all
    
    Closes: https://bugs.gentoo.org/943761
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/flag-o-matic.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)