Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943695 - app-office/libreoffice w/ app-text/poppler-24.12.0: sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:1104:24: error: no matching function for call to ‘Stream::getImageParams(int*, StreamColorSpaceMode*)’
Summary: app-office/libreoffice w/ app-text/poppler-24.12.0: sdext/source/pdfimport/xp...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-11-17 19:49 UTC by jospezial
Modified: 2025-01-13 17:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info (emerge--info.txt,11.02 KB, text/plain)
2024-11-17 19:49 UTC, jospezial 		Details
build.log (build.log.gz,145.21 KB, application/gzip)
2024-11-17 19:51 UTC, jospezial 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2024-11-17 19:49:26 UTC 
Created attachment 908893 [details]
emerge --info

[PKG] sdext_pdfimport_pdf
/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In member function ‘virtual void pdfi::PDFOutDev::drawImageMask(GfxState*, Object*, Stream*, int, int, pdfi::poppler_bool, pdfi::poppler_bool, pdfi::poppler_bool)’:
/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:1104:24: error: no matching function for call to ‘Stream::getImageParams(int*, StreamColorSpaceMode*)’
 1104 |     str->getImageParams( &bitsPerComponent, &csMode );
      |     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/poppler/Object.h:595,
                 from /usr/include/poppler/GfxState.h:43,
                 from /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36,
                 from /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:20:
/usr/include/poppler/Stream.h:255:18: note: candidate: ‘virtual void Stream::getImageParams(int*, StreamColorSpaceMode*, bool*)’
  255 |     virtual void getImageParams(int * /*bitsPerComponent*/, StreamColorSpaceMode * /*csMode*/, bool * /*hasAlpha*/) { }
      |                  ^~~~~~~~~~~~~~
/usr/include/poppler/Stream.h:255:18: note:   candidate expects 3 arguments, 2 provided
make[1]: *** [/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/solenv/gbuild/LinkTarget.mk:339: /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/CxxObject/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.o] Error 1
Comment 1 jospezial 2024-11-17 19:51:20 UTC 
Created attachment 908894 [details]
build.log
Comment 2 Andreas Sturmlechner gentoo-dev 2024-11-17 19:55:27 UTC 
Do not block stabilisation unless app-office/libreoffice-24.2.7.2 is broken.
Comment 3 jospezial 2024-11-17 22:20:03 UTC 
/var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In member function ‘virtual void pdfi::PDFOutDev::drawImageMask(GfxState*, Object*, Stream*, int, int, pdfi::poppler_bool, pdfi::poppler_bool, pdfi::poppler_bool)’:
/var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:1040:24: error: no matching function for call to ‘Stream::getImageParams(int*, StreamColorSpaceMode*)’
 1040 |     str->getImageParams( &bitsPerComponent, &csMode );
      |     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/poppler/Object.h:595,
                 from /usr/include/poppler/GfxState.h:43,
                 from /var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36,
                 from /var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:20:
/usr/include/poppler/Stream.h:255:18: note: candidate: ‘virtual void Stream::getImageParams(int*, StreamColorSpaceMode*, bool*)’
  255 |     virtual void getImageParams(int * /*bitsPerComponent*/, StreamColorSpaceMode * /*csMode*/, bool * /*hasAlpha*/) { }
      |                  ^~~~~~~~~~~~~~
/usr/include/poppler/Stream.h:255:18: note:   candidate expects 3 arguments, 2 provided
make[1]: *** [/var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/solenv/gbuild/LinkTarget.mk:340: /var/tmp/portage/app-office/libreoffice-24.2.7.2/work/libreoffice-24.2.7.2/workdir/CxxObject/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.o] Error 1
Comment 4 jospezial 2024-11-17 23:07:26 UTC 
It looks as compilation goes through with app-text/poppler-24.11.0-r1 .  
app-office/libreoffice-9999

[CXX] sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
S=/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/ $W/Dep/CxxObject/sdext/source/pdfimport/xpdfwrapper/ && cd /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 &&            x86_64-pc-linux-gnu-g++  -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -DX86_64 -D_PTHREADS -D_REENTRANT  -DSYSTEM_EXPAT  -DSYSTEM_ZLIB -DZLIB_CONST  -DSYSTEM_POPPLER   -fvisibility=hidden    -Wall -Wno-missing-braces -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros  -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe  -fstack-protector-strong  -Wdeprecated-copy-dtor -Wduplicated-cond -Wlogical-op -Wshift-overflow=2 -Wunused-const-variable=1 -fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual -std=c++20 -pthread  -march=native -mtune=native -O2 -pipe  -fexceptions -fno-enforce-eh-specs    -DLIBO_INTERNAL_ONLY  -c $S/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx -o $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.o  -isystem /usr/include/poppler/cpp -isystem /usr/include/poppler -I$S/include -I/opt/openjdk-bin-21.0.5_p11/include -I/opt/openjdk-bin-21.0.5_p11/include/linux -I$S/config_host  -I/usr/include     -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include     -isystem /usr/include/libpng16      -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include    
[CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
S=/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/ $W/Dep/CxxObject/sdext/source/pdfimport/xpdfwrapper/ && cd /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 &&            x86_64-pc-linux-gnu-g++  -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -DX86_64 -D_PTHREADS -D_REENTRANT  -DSYSTEM_EXPAT  -DSYSTEM_ZLIB -DZLIB_CONST  -DSYSTEM_POPPLER   -fvisibility=hidden    -Wall -Wno-missing-braces -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros  -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe  -fstack-protector-strong  -Wdeprecated-copy-dtor -Wduplicated-cond -Wlogical-op -Wshift-overflow=2 -Wunused-const-variable=1 -fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual -std=c++20 -pthread  -march=native -mtune=native -O2 -pipe  -fexceptions -fno-enforce-eh-specs    -DLIBO_INTERNAL_ONLY  -c $S/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx -o $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/pnghelper.o  -isystem /usr/include/poppler/cpp -isystem /usr/include/poppler -I$S/include -I/opt/openjdk-bin-21.0.5_p11/include -I/opt/openjdk-bin-21.0.5_p11/include/linux -I$S/config_host  -I/usr/include     -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include     -isystem /usr/include/libpng16      -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include    
[CXX] sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
S=/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/ $W/Dep/CxxObject/sdext/source/pdfimport/xpdfwrapper/ && cd /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 &&            x86_64-pc-linux-gnu-g++  -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -DX86_64 -D_PTHREADS -D_REENTRANT  -DSYSTEM_EXPAT  -DSYSTEM_ZLIB -DZLIB_CONST  -DSYSTEM_POPPLER   -fvisibility=hidden    -Wall -Wno-missing-braces -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros  -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe  -fstack-protector-strong  -Wdeprecated-copy-dtor -Wduplicated-cond -Wlogical-op -Wshift-overflow=2 -Wunused-const-variable=1 -fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual -std=c++20 -pthread  -march=native -mtune=native -O2 -pipe  -fexceptions -fno-enforce-eh-specs    -DLIBO_INTERNAL_ONLY  -c $S/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx -o $W/CxxObject/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.o  -isystem /usr/include/poppler/cpp -isystem /usr/include/poppler -I$S/include -I/opt/openjdk-bin-21.0.5_p11/include -I/opt/openjdk-bin-21.0.5_p11/include/linux -I$S/config_host  -I/usr/include     -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include     -isystem /usr/include/libpng16      -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include    
[PKG] sdext_pdfimport_pdf
Comment 5 Andreas Sturmlechner gentoo-dev 2024-11-18 19:36:13 UTC 
poppler git commit at the time of build failure? Or was it literally 24.11.0, as mentioned in $summary? (consider that release broken without our patches)
Comment 6 jospezial 2024-11-18 20:31:25 UTC 
I rebuilt poppler right before I tried to rebuild libreoffice.
So it must have been at
https://gitlab.freedesktop.org/poppler/poppler/-/commit/92cf4406b1c41d3f59aa5c80dd8f761d0ef61a18
from 15.11.

One commit between this and the poppler 24.11.0 release commit must cause the break. But I have not found which wile looking at. I did not bisect.
And we can exclude the commits as cause that were added as patches to app-text/poppler-24.11.0-r1.

We have to deal with it when poppler-24.12 comes, if it is not fixed upstream by libreoffice then.

Btw, the app-office/libreoffice live ebuild needs some changes.
I will post my changes in another bug.
I have seen you are working on it too.
Comment 8 jospezial 2025-01-08 10:02:18 UTC 
https://github.com/LibreOffice/core/commit/aa94faf493945e854a888e809a9c5cc8d6d0b978
"sdext: adapt xpdfwrapper to poppler 24.12"

https://gerrit.libreoffice.org/q/poppler
backports are wip
Comment 9 jospezial 2025-01-09 18:47:37 UTC 
After the upstream fix I successfully compiled my libreoffice-9999 against poppler-25.1.
Comment 10 Larry the Git Cow gentoo-dev 2025-01-13 17:12:11 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1039f892288d6ae6c9a41013efba264779e7b28

commit a1039f892288d6ae6c9a41013efba264779e7b28
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-01-12 21:46:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-13 17:11:52 +0000

    app-office/libreoffice: Fix build w/ app-text/poppler-24.12
    
    Closes: https://bugs.gentoo.org/943695
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/libreoffice-24.2.7.2-poppler-24.12.patch | 38 ++++++++++++++++++++++
 app-office/libreoffice/libreoffice-24.2.7.2.ebuild |  3 +-
 2 files changed, 40 insertions(+), 1 deletion(-)