Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943686 - media-sound/frescobaldi should depend on media-libs/portmidi for midi functionality
Summary: media-sound/frescobaldi should depend on media-libs/portmidi for midi functio...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-17 16:32 UTC by Benedikt Reinartz
Modified: 2025-03-30 08:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benedikt Reinartz 2024-11-17 16:32:35 UTC
Without media-libs/portmidi installed, playback fails.

It is enough to add it to the dependencies (maybe behind a "+midi" use flag?).

Reproducible: Always

Steps to Reproduce:
1. Install frescobaldi and ensure that portmidi is not installed
2. Start a midi synth (e.g. fluidsynth via qsynth)
3. Try to play something
Actual Results:  
Frescobaldi complains about missing portmidi libraries.

Expected Results:  
Playback should start.
Comment 1 Ionen Wolkens gentoo-dev 2025-03-30 02:00:04 UTC
You mean it works with portmidi installed? Given the python bindings are gone from that package, it shouldn't be enough.

However, dev-python/pygame provides an alternative to that and afaik it's what needs to be installed (it also depends on portmidi).
Comment 2 Ionen Wolkens gentoo-dev 2025-03-30 02:21:09 UTC
Ah nevermind, it should work with just portmidi, I hadn't noticed the "last resort" third alternative.

* For MIDI the PortMidi library is used, either via importing 'pypm',
  'pyportmidi._pyportmidi', or, if that is not available, loading the
  pygame.pypm module from pygame; or, as a last resort, embedding the PortMidi
  C-library via ctypes. For example, under Debian/Ubuntu, `sudo apt install
  python3-pygame`, and on Fedora, `sudo dnf install python3-pygame`.
Comment 3 Ionen Wolkens gentoo-dev 2025-03-30 02:21:50 UTC
(given it's a small dependency, I think I might just hard-depend on it so runtime works as expected)
Comment 4 Larry the Git Cow gentoo-dev 2025-03-30 08:20:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5206c2b51ecf13aed785ae3529ca8c918bae46d6

commit 5206c2b51ecf13aed785ae3529ca8c918bae46d6
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2025-03-30 01:54:10 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2025-03-30 08:19:37 +0000

    media-sound/frescobaldi: add 4.0.0
    
    Hardly know this so not really tested beyond checking if it starts
    and seems normal, please report if find any downstream packaging
    issues, or major issues that we should backport fixes for before
    potential stable (after reporting upstream if not already).
    
    Please also CC me for downstream bugs for now, haven't added myself as
    maintainer given may not handle this package long term (just trying to
    get it in a good state to be easier to handle for other maintainers).
    
    If no major issues, hoping to stabilize before the py3.13 target switch
    in May (3.13 is not on 3.3.0, untested) and soon follow that by 3.3.0
    removal to allow pyqtwebengine (Qt5) cleanup.
    
    Closes: https://bugs.gentoo.org/905637
    Closes: https://bugs.gentoo.org/926681
    Closes: https://bugs.gentoo.org/943686
    Closes: https://bugs.gentoo.org/952546
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 media-sound/frescobaldi/Manifest                 |  1 +
 media-sound/frescobaldi/frescobaldi-4.0.0.ebuild | 68 ++++++++++++++++++++++++
 2 files changed, 69 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b430b6aa7a8c6d8a1558e287f196dca74169b0db

commit b430b6aa7a8c6d8a1558e287f196dca74169b0db
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2025-03-30 03:19:58 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2025-03-30 08:19:36 +0000

    media-sound/frescobaldi: cleanup metadata.xml portmidi comment
    
    Will be hard-depending on portmidi now as it's expected for proper
    functionality (and is a small dep) and so the USE description will
    not need to be restored.
    
    Bug: https://bugs.gentoo.org/943686
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 media-sound/frescobaldi/metadata.xml | 5 -----
 1 file changed, 5 deletions(-)