Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943404 - dev-lang/luajit-2.1.9999999999: broken symlink at /usr/bin/luajit
Summary: dev-lang/luajit-2.1.9999999999: broken symlink at /usr/bin/luajit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-11-14 01:26 UTC by Artemis Everfree
Modified: 2024-11-14 03:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Artemis Everfree 2024-11-14 01:26:39 UTC
We do `dosym luajit-"${PV}" /usr/bin/luajit`, but the luajit binary path is actually versioned with the git timestamp (as is used as the package version in the non-9999 ebuilds). 

QA Notice tried to tell me this, but I did not see it. I will fix it up.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2024-11-14 03:23:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd75a9dac59efef496f2fafac20ebe42f2c4fcd0

commit dd75a9dac59efef496f2fafac20ebe42f2c4fcd0
Author:     Artemis Everfree <artemis@artemis.sh>
AuthorDate: 2024-11-14 02:35:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-14 03:22:34 +0000

    dev-lang/luajit: Use luajit_relver in bin symlink
    
    Previously we were generating this symlink:
    
        /usr/bin/luajit -> /usr/bin/luajit-${PV}
    
    This failed for 2.1.9999999999, as the binary was instead at
    /usr/bin/luajit-2.1.${relver}, for the corresponding relver
    of the commit.
    
    We now read `src/luajit_relver.txt` generated by luajit's
    build process, which always contains the correct relver
    suffix for both snapshot and live builds.
    
    The 9999999999 support is also now agnostic to which release
    channel is being built, so a theoretical 2.2.9999999999
    could be supported by copying the 2.1.9999999999 ebuild
    without modification.
    
    Closes: https://bugs.gentoo.org/943404
    Signed-off-by: Artemis Everfree <artemis@artemis.sh>
    Closes: https://github.com/gentoo/gentoo/pull/39312
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lang/luajit/luajit-2.1.1727870382.ebuild | 30 +++++++++++++++++++++-------
 dev-lang/luajit/luajit-2.1.9999999999.ebuild | 30 +++++++++++++++++++++-------
 2 files changed, 46 insertions(+), 14 deletions(-)