Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943038 - games-simulation/openrct2-0.4.16 fails to compile: RideRatings.cpp:368:24: error: invalid use of incomplete type struct TileElement
Summary: games-simulation/openrct2-0.4.16 fails to compile: RideRatings.cpp:368:24: er...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-11-09 07:03 UTC by Agostino Sarubbo
Modified: 2024-11-23 23:36 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,753.95 KB, text/plain)
2024-11-09 07:03 UTC, Agostino Sarubbo
Details
TileElement patch (TileElement.patch,463 bytes, patch)
2024-11-10 09:05 UTC, Marcin Deranek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-11-09 07:03:49 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-simulation/openrct2-0.4.16 fails to compile.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-11-09 07:03:50 UTC
Created attachment 908169 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-11-09 07:03:51 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/libopenrct2.dir/src/openrct2/ride/RideRatings.cpp.o 
/var/tmp/portage/games-simulation/openrct2-0.4.16/work/OpenRCT2-0.4.16/src/openrct2/ride/RideRatings.cpp:368:24: error: invalid use of incomplete type ‘struct TileElement’
Comment 3 Marcin Deranek 2024-11-10 09:05:17 UTC
Created attachment 908360 [details, diff]
TileElement patch
Comment 4 Marcin Deranek 2024-11-10 09:07:36 UTC
Feel free to try an attached patch (not upstream) which allowed me to compile and run openrct2-0.4.16
Comment 5 manwe 2024-11-10 11:52:10 UTC
I confirm that the patch works, the game compiles correctly.
Comment 6 Conrad Kostecki gentoo-dev 2024-11-10 12:45:54 UTC
I do wonder, why it does not fail for me. Will submit patch.
Comment 7 Petr Šourek 2024-11-12 10:37:28 UTC
Failing for me as well, but patch is working. Thanks.
Comment 8 Agostino Sarubbo gentoo-dev 2024-11-12 11:04:41 UTC
(In reply to Conrad Kostecki from comment #6)
> I do wonder, why it does not fail for me. Will submit patch.

I can only think a different compiler version
Comment 9 Larry the Git Cow gentoo-dev 2024-11-23 23:36:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f5fc1cb62aada859e90353a8647dd4931ab91e3

commit 2f5fc1cb62aada859e90353a8647dd4931ab91e3
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-11-22 23:44:15 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-11-23 23:32:58 +0000

    games-simulation/openrct2: fix build
    
    Closes: https://bugs.gentoo.org/943038
    Closes: https://bugs.gentoo.org/941519
    
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../openrct2/files/openrct2-0.4.16-tileelement.patch           | 10 ++++++++++
 games-simulation/openrct2/openrct2-0.4.16.ebuild               |  1 +
 2 files changed, 11 insertions(+)