Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943009 - app-text/calibre-7.19.0 fails test calibre.test_build.BuildTest.test_imaging
Summary: app-text/calibre-7.19.0 fails test calibre.test_build.BuildTest.test_imaging
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Zac Medico
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-08 03:04 UTC by Jonathan Lovelace
Modified: 2024-11-10 21:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-text:calibre-7.19.0:20241108-024754.log (app-text:calibre-7.19.0:20241108-024754.log,97.25 KB, text/plain; charset=utf-8)
2024-11-08 03:04 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,8.67 KB, text/plain; charset=utf-8)
2024-11-08 03:04 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2024-11-08 03:04:09 UTC
Created attachment 908122 [details]
app-text:calibre-7.19.0:20241108-024754.log

When rebuilding due to a subslot change in some dependency, =app-text/calibre-7.19.0 fails its test phase, specifically the test calibre.test_build.BuildTest.test_imaging:

======================================================================
FAIL: test_imaging (calibre.test_build.BuildTest.test_imaging)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/app-text/calibre-7.19.0/work/calibre-7.19.0/src/calibre/test_build.py", line 444, in test_imaging
    self.assertIn(line.strip(), out)
AssertionError: '--- WEBP Transparency support ok' not found in '--------------------------------------------------------------------\nPillow 11.0.0\nPython 3.12.6 (main, Oct 11 2024, 11:04:28) [GCC 12.4.0]\n--------------------------------------------------------------------\nPython executable is /usr/bin/python3.12\nSystem Python files loaded from /usr\n--------------------------------------------------------------------\nPython Pillow modules loaded from /usr/lib/python3.12/site-packages/PIL\nBinary Pillow modules loaded from /usr/lib/python3.12/site-packages/PIL\n--------------------------------------------------------------------\n--- PIL CORE support ok, compiled for 11.0.0\n--- TKINTER support ok, loaded 8.6\n--- FREETYPE2 support ok, loaded 2.13.2\n--- LITTLECMS2 support ok, loaded 2.16\n--- WEBP support ok, loaded 1.4.0\n--- JPEG support ok, compiled for libjpeg-turbo 3.0.3\n--- OPENJPEG (JPEG2000) support ok, loaded 2.5.2\n--- ZLIB (PNG/ZIP) support ok, loaded 1.3.1\n--- LIBTIFF support ok, loaded 4.6.0\n--- RAQM (Bidirectional Text) support ok, loaded 0.10.1, fribidi 1.0.13, harfbuzz 9.0.0\n*** LIBIMAGEQUANT (Quantization method) support not installed\n--- XCB (X protocol) support ok\n--------------------------------------------------------------------\n'
Comment 1 Jonathan Lovelace 2024-11-08 03:04:52 UTC
Created attachment 908123 [details]
emerge-info.txt
Comment 2 Eli Schwartz gentoo-dev 2024-11-10 03:24:15 UTC
calibre is testing the output of PIL.features.pilinfo(supported_formats=False) to verify that all supported formats calibre relies upon actually exist.

If we take a look at the assertion error you got, and print the python string for formatting reasons:


--------------------------------------------------------------------
Pillow 11.0.0
Python 3.12.6 (main, Oct 11 2024, 11:04:28) [GCC 12.4.0]
--------------------------------------------------------------------
Python executable is /usr/bin/python3.12
System Python files loaded from /usr
--------------------------------------------------------------------
Python Pillow modules loaded from /usr/lib/python3.12/site-packages/PIL
Binary Pillow modules loaded from /usr/lib/python3.12/site-packages/PIL
--------------------------------------------------------------------
--- PIL CORE support ok, compiled for 11.0.0
--- TKINTER support ok, loaded 8.6
--- FREETYPE2 support ok, loaded 2.13.2
--- LITTLECMS2 support ok, loaded 2.16
--- WEBP support ok, loaded 1.4.0
--- JPEG support ok, compiled for libjpeg-turbo 3.0.3
--- OPENJPEG (JPEG2000) support ok, loaded 2.5.2
--- ZLIB (PNG/ZIP) support ok, loaded 1.3.1
--- LIBTIFF support ok, loaded 4.6.0
--- RAQM (Bidirectional Text) support ok, loaded 0.10.1, fribidi 1.0.13, harfbuzz 9.0.0
*** LIBIMAGEQUANT (Quantization method) support not installed
--- XCB (X protocol) support ok
--------------------------------------------------------------------



calibre is complaining that it could not find "WEBP Transparency support ok" -- and sure enough, you can see that WEBP is mentioned but not anything about transparency.

Tests do pass for calibre 7.21 (which I haven't packaged yet but should do so ASAP), since https://github.com/kovidgoyal/calibre/commit/a961ddbfcb96461fd830ccd6facb81d69cc679d8 which just checks for WEBP but not the other nitpicky specifics.

As noted in the commit message, pillow itself changed how it messages this infomation. So the tests stopped passing due to a recent pillow upgrade.
Comment 3 Jonathan Lovelace 2024-11-10 19:31:40 UTC
I tried putting that commit (a961ddbfcb96461fd830ccd6facb81d69cc679d8) as a patch into /etc/portage/patches/app-text/calibre-7.19.0 , and after I did the test passed (as one would expect).
Comment 4 Larry the Git Cow gentoo-dev 2024-11-10 21:29:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ec870832e8716826b3081329dd0ea0e551e9f33

commit 4ec870832e8716826b3081329dd0ea0e551e9f33
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-11-10 21:26:23 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-11-10 21:29:19 +0000

    app-text/calibre: add 7.21.0
    
    Closes: https://bugs.gentoo.org/943009
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 app-text/calibre/Manifest              |   2 +
 app-text/calibre/calibre-7.21.0.ebuild | 253 +++++++++++++++++++++++++++++++++
 2 files changed, 255 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ddb78d1ccd58984d9f01154a20cf5ab3be4233f

commit 4ddb78d1ccd58984d9f01154a20cf5ab3be4233f
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-11-10 21:28:19 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-11-10 21:29:19 +0000

    app-text/calibre: backport patch to fix tests with pillow 11
    
    Apply the fix to stable in addition to packaging the new version.
    
    Bug: https://bugs.gentoo.org/943009
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 app-text/calibre/calibre-7.19.0.ebuild             |  2 ++
 app-text/calibre/calibre-7.20.0.ebuild             |  2 ++
 ...PIL-11.0-changes-its-webp-features-output.patch | 36 ++++++++++++++++++++++
 3 files changed, 40 insertions(+)