Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942919 - media-gfx/freecad-9999 - enable revision detection
Summary: media-gfx/freecad-9999 - enable revision detection
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paul Zander
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-05 16:55 UTC by Fabio Rossi
Modified: 2024-11-20 10:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
freecad-9999-Gentoo-specific-don-t-check-vcs.patch (freecad-9999-Gentoo-specific-don-t-check-vcs.patch,325 bytes, patch)
2024-11-05 16:55 UTC, Fabio Rossi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2024-11-05 16:55:14 UTC
Created attachment 907976 [details, diff]
freecad-9999-Gentoo-specific-don-t-check-vcs.patch

freecad-9999 is built from git sources, at compile time it is possible to detect the git revision used to build (without internet access).

The current patch freecad-9999-Gentoo-specific-don-t-check-vcs.patch disables that possibility, this results in the following startup banner:

FreeCAD 1.1.0, Libs: 1.1.0devRUnknown
(C) 2001-2024 FreeCAD contributors -azz
FreeCAD is free and open-source software licensed under the terms of LGPL2+ license.

By relaxing the patch with the attached version I can get 

FreeCAD 1.1.0, Libs: 1.1.0devR39132 (Git)
(C) 2001-2024 FreeCAD contributors
FreeCAD is free and open-source software licensed under the terms of LGPL2+ license.

This helps when reporting bugs upstream.

Please note that the 1.0_rc* ebuilds use the same patch but in that case it is the wanted behaviour due to absence of .git files in ${S}. So there must be two different patches to support both 1.0_rc* and 9999 ebuilds.
Comment 1 Larry the Git Cow gentoo-dev 2024-11-20 10:31:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30734cfc1abfbbdcfb41effc36d607f77c9f7f76

commit 30734cfc1abfbbdcfb41effc36d607f77c9f7f76
Author:     Nowa Ammerlaan <nowa@gentoo.org>
AuthorDate: 2024-11-20 10:27:45 +0000
Commit:     Nowa Ammerlaan <nowa@gentoo.org>
CommitDate: 2024-11-20 10:31:06 +0000

    media-gfx/freecad: add 1.0.0
    
    Closes: https://bugs.gentoo.org/944018
    Closes: https://bugs.gentoo.org/942919
    Signed-off-by: Nowa Ammerlaan <nowa@gentoo.org>

 media-gfx/freecad/Manifest                         |   1 +
 ...cad-1.0.0-Gentoo-specific-don-t-check-vcs.patch |  15 +
 ...ecad-9999-Gentoo-specific-don-t-check-vcs.patch |   5 +-
 media-gfx/freecad/freecad-1.0.0.ebuild             | 390 +++++++++++++++++++++
 4 files changed, 408 insertions(+), 3 deletions(-)